[GitHub] [pinot] yuanbenson1772 commented on a diff in pull request #9006: Add Segment Lineage List API #9005

[GitBox <gi...@apache.org>]

yuanbenson1772 commented on code in PR #9006:
URL: https://github.com/apache/pinot/pull/9006#discussion_r917465894


##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java:
##########
@@ -652,6 +652,29 @@ public Response endReplaceSegments(
     }
   }
 
+  @GET
+  @Path("segments/{tableName}/listSegmentLineage")
+  @Authenticate(AccessType.READ)
+  @Produces(MediaType.APPLICATION_JSON)
+  @ApiOperation(value = "List segment lineage", notes = "List segment lineage")
+  public Response listSegmentLineage(

Review Comment:
   Raised some concerns in the `#Testing done` section of the PR description. Namely, `PinotSegmentUploadDownloadRestletResourceTest` does not seem to cover any segment operations integration tests (as it requires table creation and segment upload) and such operations are tested in `PinotHelixResourceManagerTest` though. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org