You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by nsuthar <gi...@git.apache.org> on 2014/04/24 01:34:28 UTC
[GitHub] spark pull request: Fixed bug for Jira Issue# 1527
GitHub user nsuthar opened a pull request:
https://github.com/apache/spark/pull/517
Fixed bug for Jira Issue# 1527
Details: rootDirs in DiskBlockManagerSuite doesn't get full path from rootDir0, rootDir1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuthar/spark bugFixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/517.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #517
----
commit 6c25d6b92c5564ad455b9d065fc1e983c3ff08ea
Author: nirajguavus <ni...@gmail.com>
Date: 2014-04-23T23:23:23Z
Fixed bug for Jira Issue# 1527
Details: rootDirs in DiskBlockManagerSuite doesn't get full path from rootDir0, rootDir1
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed bug for Jira Issue# 1527
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/517#issuecomment-41243761
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14426/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed bug for Jira Issue# 1527
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/517#issuecomment-41244038
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed bug for Jira Issue# 1527
Posted by nsuthar <gi...@git.apache.org>.
Github user nsuthar commented on the pull request:
https://github.com/apache/spark/pull/517#issuecomment-41315223
removed import statement causing compilation error and build it locally...seems to be fixed now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed bug for Jira Issue# 1527
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/517#issuecomment-41228105
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed bug for Jira Issue# 1527
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/517#issuecomment-41243367
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed bug for Jira Issue# 1527
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/517#issuecomment-41245179
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14427/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed bug for Jira Issue# 1527
Posted by nsuthar <gi...@git.apache.org>.
GitHub user nsuthar reopened a pull request:
https://github.com/apache/spark/pull/517
Fixed bug for Jira Issue# 1527
Details: rootDirs in DiskBlockManagerSuite doesn't get full path from rootDir0, rootDir1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuthar/spark bugFixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/517.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #517
----
commit 6c25d6b92c5564ad455b9d065fc1e983c3ff08ea
Author: nirajguavus <ni...@gmail.com>
Date: 2014-04-23T23:23:23Z
Fixed bug for Jira Issue# 1527
Details: rootDirs in DiskBlockManagerSuite doesn't get full path from rootDir0, rootDir1
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed bug for Jira Issue# 1527
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/517#issuecomment-41243159
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed bug for Jira Issue# 1527
Posted by aarondav <gi...@git.apache.org>.
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/517#discussion_r11937108
--- Diff: core/src/test/scala/org/apache/spark/storage/DiskBlockManagerSuite.scala ---
@@ -26,6 +26,7 @@ import com.google.common.io.Files
import org.scalatest.{BeforeAndAfterEach, FunSuite}
import org.apache.spark.SparkConf
+import java.nio.file.Files
--- End diff --
I don't think this import is required (and it's causing a compile error anyway).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed bug for Jira Issue# 1527
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/517#issuecomment-41245178
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed bug for Jira Issue# 1527
Posted by nsuthar <gi...@git.apache.org>.
Github user nsuthar commented on the pull request:
https://github.com/apache/spark/pull/517#issuecomment-41321790
build passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed bug for Jira Issue# 1527
Posted by nsuthar <gi...@git.apache.org>.
Github user nsuthar closed the pull request at:
https://github.com/apache/spark/pull/517
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed bug for Jira Issue# 1527
Posted by nsuthar <gi...@git.apache.org>.
Github user nsuthar commented on the pull request:
https://github.com/apache/spark/pull/517#issuecomment-41227586
I have emailed the person who has opened this Jira ...I am waiting for him to assign it to me...if someone can assign it to me thn I can change Jira bug status appropritely.
Email: nirajsuthar@gmail.com
Thank you,
Niraj
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed bug for Jira Issue# 1527
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/517#issuecomment-41243364
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed bug for Jira Issue# 1527
Posted by nsuthar <gi...@git.apache.org>.
Github user nsuthar closed the pull request at:
https://github.com/apache/spark/pull/517
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed bug for Jira Issue# 1527
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/517#issuecomment-41244185
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed bug for Jira Issue# 1527
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/517#issuecomment-41243759
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed bug for Jira Issue# 1527
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/517#issuecomment-41244191
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---