You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by dp...@apache.org on 2019/02/05 11:38:54 UTC
[ignite] 02/06: IGNITE-11006: Enable problematic whitespace
inspection check (#5951)
This is an automated email from the ASF dual-hosted git repository.
dpavlov pushed a commit to branch ignite-11191
in repository https://gitbox.apache.org/repos/asf/ignite.git
commit 3dd007430f753b913e98b78bab84254dca47af4b
Author: Nikolay <ni...@apache.org>
AuthorDate: Tue Feb 5 08:46:19 2019 +0300
IGNITE-11006: Enable problematic whitespace inspection check (#5951)
* Enable problematic whitespace inspection check
* Fixes for existing code inspections
---
idea/ignite_inspections_teamcity.xml | 3 +-
.../main/java/org/apache/ignite/IgniteCache.java | 6 +-
.../ignite/IgniteCacheRestartingException.java | 1 -
.../jdbc/thin/JdbcThinDatabaseMetadata.java | 1 -
.../managers/discovery/GridDiscoveryManager.java | 1 -
.../IgniteDiscoverySpiInternalListener.java | 2 +-
.../processors/cache/GridCacheAdapter.java | 1 -
.../dht/preloader/CacheGroupAffinityMessage.java | 1 -
.../dht/preloader/GridDhtPartitionDemander.java | 1 -
.../pagemem/DelayedPageReplacementTracker.java | 1 -
.../verify/VerifyBackupPartitionsDumpTask.java | 1 -
.../distributed/DistributedBooleanProperty.java | 3 -
.../distributed/DistributedComparableProperty.java | 1 -
.../distributed/DistributedLongProperty.java | 3 -
.../distributed/DistributedPropertyDispatcher.java | 2 -
.../processors/odbc/jdbc/JdbcRequestHandler.java | 2 +-
.../processors/service/IgniteServiceProcessor.java | 2 -
.../processors/service/ServiceDeploymentTask.java | 3 +-
.../org/apache/ignite/plugin/PluginProvider.java | 3 +-
.../tcp/ipfinder/jdbc/JdbcIpFinderDialect.java | 10 ++--
.../ipfinder/jdbc/TcpDiscoveryJdbcIpFinder.java | 10 ++--
.../sharedfs/TcpDiscoverySharedFsIpFinder.java | 2 -
.../ignite/transactions/TransactionException.java | 66 +++++++++++-----------
.../internal/ClusterNodeMetricsSelfTest.java | 3 -
.../internal/GridNonHistoryMetricsSelfTest.java | 5 --
.../internal/commandline/CommandArgFactory.java | 1 -
.../GridCacheAbstractNodeRestartSelfTest.java | 2 -
.../distributed/GridCacheLockAbstractTest.java | 1 -
.../closure/GridClosureSerializationTest.java | 1 -
.../processors/igfs/IgfsMetricsSelfTest.java | 1 -
.../internal/processors/igfs/IgfsSizeSelfTest.java | 3 -
.../GridServiceProcessorBatchDeploySelfTest.java | 1 -
.../ignite/lang/GridBasicPerformanceTest.java | 4 +-
.../TcpDiscoveryReconnectUnstableTopologyTest.java | 1 -
.../testframework/junits/GridAbstractTest.java | 3 +-
.../junits/spi/GridSpiAbstractTest.java | 1 -
.../ignite/testsuites/IgnitePdsTestSuite.java | 1 -
37 files changed, 54 insertions(+), 100 deletions(-)
diff --git a/idea/ignite_inspections_teamcity.xml b/idea/ignite_inspections_teamcity.xml
index 3b58d3a..10d3c21 100644
--- a/idea/ignite_inspections_teamcity.xml
+++ b/idea/ignite_inspections_teamcity.xml
@@ -11,6 +11,7 @@
<option name="m_requireAnnotationsFirst" value="false" />
</inspection_tool>
<inspection_tool class="RedundantSuppression" enabled="true" level="ERROR" enabled_by_default="true" />
+ <inspection_tool class="ProblematicWhitespace" enabled="true" level="ERROR" enabled_by_default="true" />
<!-- Disabled inspetions -->
<inspection_tool class="AbsoluteAlignmentInUserInterface" enabled="false" level="WARNING" enabled_by_default="false"/>
<inspection_tool class="AbstractBeanReferencesInspection" enabled="false" level="ERROR" enabled_by_default="false"/>
@@ -1457,4 +1458,4 @@
<option name="ADD_SERVLET_TO_ENTRIES" value="false"/>
<option name="ADD_NONJAVA_TO_ENTRIES" value="true"/>
</inspection_tool>
-</profile>
\ No newline at end of file
+</profile>
diff --git a/modules/core/src/main/java/org/apache/ignite/IgniteCache.java b/modules/core/src/main/java/org/apache/ignite/IgniteCache.java
index 395c8f8..12329db 100644
--- a/modules/core/src/main/java/org/apache/ignite/IgniteCache.java
+++ b/modules/core/src/main/java/org/apache/ignite/IgniteCache.java
@@ -1236,7 +1236,7 @@ public interface IgniteCache<K, V> extends javax.cache.Cache<K, V>, IgniteAsyncS
* @throws TransactionException If operation within transaction is failed.
*/
public <T> IgniteFuture<T> invokeAsync(K key, EntryProcessor<K, V, T> entryProcessor, Object... arguments)
- throws TransactionException;
+ throws TransactionException;
/**
* Invokes an {@link CacheEntryProcessor} against the {@link javax.cache.Cache.Entry} specified by
@@ -1270,7 +1270,7 @@ public interface IgniteCache<K, V> extends javax.cache.Cache<K, V>, IgniteAsyncS
*/
@IgniteAsyncSupported
public <T> T invoke(K key, CacheEntryProcessor<K, V, T> entryProcessor, Object... arguments)
- throws TransactionException;
+ throws TransactionException;
/**
* Asynchronously invokes an {@link CacheEntryProcessor} against the {@link javax.cache.Cache.Entry} specified by
@@ -1300,7 +1300,7 @@ public interface IgniteCache<K, V> extends javax.cache.Cache<K, V>, IgniteAsyncS
* @see CacheEntryProcessor
*/
public <T> IgniteFuture<T> invokeAsync(K key, CacheEntryProcessor<K, V, T> entryProcessor, Object... arguments)
- throws TransactionException;
+ throws TransactionException;
/**
* {@inheritDoc}
diff --git a/modules/core/src/main/java/org/apache/ignite/IgniteCacheRestartingException.java b/modules/core/src/main/java/org/apache/ignite/IgniteCacheRestartingException.java
index 1dbfc67..04d99a9 100644
--- a/modules/core/src/main/java/org/apache/ignite/IgniteCacheRestartingException.java
+++ b/modules/core/src/main/java/org/apache/ignite/IgniteCacheRestartingException.java
@@ -18,7 +18,6 @@
package org.apache.ignite;
-import org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion;
import org.apache.ignite.lang.IgniteFuture;
import org.jetbrains.annotations.Nullable;
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinDatabaseMetadata.java b/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinDatabaseMetadata.java
index 0de592e..3b7e3cb 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinDatabaseMetadata.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/jdbc/thin/JdbcThinDatabaseMetadata.java
@@ -60,7 +60,6 @@ import static org.apache.ignite.internal.jdbc2.JdbcUtils.tableRow;
/**
* JDBC database metadata implementation.
*/
-@SuppressWarnings("RedundantCast")
public class JdbcThinDatabaseMetadata implements DatabaseMetaData {
/** Driver name. */
public static final String DRIVER_NAME = "Apache Ignite Thin JDBC Driver";
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManager.java b/modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManager.java
index 372372c..5a0402c 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManager.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/GridDiscoveryManager.java
@@ -2595,7 +2595,6 @@ public class GridDiscoveryManager extends GridManagerAdapter<DiscoverySpi> {
}
/** {@inheritDoc} */
- @SuppressWarnings("StatementWithEmptyBody")
@Override protected void body() throws InterruptedException {
long lastChk = 0;
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/IgniteDiscoverySpiInternalListener.java b/modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/IgniteDiscoverySpiInternalListener.java
index 8016423..6b25e9f 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/IgniteDiscoverySpiInternalListener.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/IgniteDiscoverySpiInternalListener.java
@@ -36,7 +36,7 @@ public interface IgniteDiscoverySpiInternalListener {
* @param locNode Local node.
* @param log Logger.
*/
- default public void beforeReconnect(ClusterNode locNode, IgniteLogger log) {
+ public default void beforeReconnect(ClusterNode locNode, IgniteLogger log) {
// No-op.
}
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java
index 8a1d358..b6dc9d6 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheAdapter.java
@@ -945,7 +945,6 @@ public abstract class GridCacheAdapter<K, V> implements IgniteInternalCache<K, V
* @throws GridCacheEntryRemovedException If entry removed.
* @throws IgniteCheckedException If failed.
*/
- @SuppressWarnings("ConstantConditions")
@Nullable private CacheObject localCachePeek0(KeyCacheObject key,
boolean heap,
boolean offheap)
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/CacheGroupAffinityMessage.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/CacheGroupAffinityMessage.java
index ef56834..c6abe89 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/CacheGroupAffinityMessage.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/CacheGroupAffinityMessage.java
@@ -22,7 +22,6 @@ import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
import java.util.Map;
-import java.util.function.Function;
import org.apache.ignite.cluster.ClusterNode;
import org.apache.ignite.internal.GridDirectCollection;
import org.apache.ignite.internal.GridDirectMap;
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionDemander.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionDemander.java
index a9ac3ff..0d0b2e8 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionDemander.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/distributed/dht/preloader/GridDhtPartitionDemander.java
@@ -64,7 +64,6 @@ import org.apache.ignite.internal.util.lang.IgniteInClosureX;
import org.apache.ignite.internal.util.tostring.GridToStringExclude;
import org.apache.ignite.internal.util.tostring.GridToStringInclude;
import org.apache.ignite.internal.util.typedef.CI1;
-import org.apache.ignite.internal.util.typedef.T2;
import org.apache.ignite.internal.util.typedef.internal.LT;
import org.apache.ignite.internal.util.typedef.internal.S;
import org.apache.ignite.internal.util.typedef.internal.U;
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/DelayedPageReplacementTracker.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/DelayedPageReplacementTracker.java
index c04073e..60f9246 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/DelayedPageReplacementTracker.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/pagemem/DelayedPageReplacementTracker.java
@@ -23,7 +23,6 @@ import java.util.Collection;
import java.util.HashSet;
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
-import org.apache.ignite.IgniteInterruptedException;
import org.apache.ignite.IgniteLogger;
import org.apache.ignite.internal.pagemem.FullPageId;
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/VerifyBackupPartitionsDumpTask.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/VerifyBackupPartitionsDumpTask.java
index 85025b5..e80ab7e 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/VerifyBackupPartitionsDumpTask.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/verify/VerifyBackupPartitionsDumpTask.java
@@ -28,7 +28,6 @@ import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.TreeMap;
-import java.util.UUID;
import org.apache.ignite.Ignite;
import org.apache.ignite.IgniteException;
import org.apache.ignite.IgniteLogger;
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/configuration/distributed/DistributedBooleanProperty.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/configuration/distributed/DistributedBooleanProperty.java
index adf69c1..c459c82 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/configuration/distributed/DistributedBooleanProperty.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/configuration/distributed/DistributedBooleanProperty.java
@@ -17,9 +17,6 @@
package org.apache.ignite.internal.processors.configuration.distributed;
-import java.io.Serializable;
-import org.apache.ignite.internal.util.lang.IgniteThrowableBiConsumer;
-
/**
* Implementation of {@link DistributedProperty} for {@link Boolean}.
*/
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/configuration/distributed/DistributedComparableProperty.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/configuration/distributed/DistributedComparableProperty.java
index 2207edf..0574288 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/configuration/distributed/DistributedComparableProperty.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/configuration/distributed/DistributedComparableProperty.java
@@ -19,7 +19,6 @@ package org.apache.ignite.internal.processors.configuration.distributed;
import java.io.Serializable;
import java.util.Objects;
-import org.apache.ignite.internal.util.lang.IgniteThrowableBiConsumer;
/**
* Implementation of {@link DistributedProperty} for {@link Comparable}.
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/configuration/distributed/DistributedLongProperty.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/configuration/distributed/DistributedLongProperty.java
index c25b841..dacd973 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/configuration/distributed/DistributedLongProperty.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/configuration/distributed/DistributedLongProperty.java
@@ -17,9 +17,6 @@
package org.apache.ignite.internal.processors.configuration.distributed;
-import java.io.Serializable;
-import org.apache.ignite.internal.util.lang.IgniteThrowableBiConsumer;
-
/**
* Implementation of {@link DistributedProperty} for {@link Long}.
*/
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/configuration/distributed/DistributedPropertyDispatcher.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/configuration/distributed/DistributedPropertyDispatcher.java
index 3178f75..acb9524 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/configuration/distributed/DistributedPropertyDispatcher.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/configuration/distributed/DistributedPropertyDispatcher.java
@@ -17,8 +17,6 @@
package org.apache.ignite.internal.processors.configuration.distributed;
-import org.apache.ignite.IgniteCheckedException;
-
/**
* Dispatcher of distributed properties.
*
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/jdbc/JdbcRequestHandler.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/jdbc/JdbcRequestHandler.java
index 9c36e71..35bb2a9 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/jdbc/JdbcRequestHandler.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/jdbc/JdbcRequestHandler.java
@@ -900,7 +900,7 @@ public class JdbcRequestHandler implements ClientListenerRequestHandler {
* @param cancel Hook for query cancellation.
* @throws QueryCancelledException If query was cancelled during execution.
*/
- @SuppressWarnings({"ForLoopReplaceableByForEach", "unchecked"})
+ @SuppressWarnings({"ForLoopReplaceableByForEach"})
private void executeBatchedQuery(SqlFieldsQueryEx qry, List<Integer> updCntsAcc,
IgniteBiTuple<Integer, String> firstErr, GridQueryCancel cancel) throws QueryCancelledException {
try {
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/service/IgniteServiceProcessor.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/service/IgniteServiceProcessor.java
index c164c6f..d993803 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/service/IgniteServiceProcessor.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/service/IgniteServiceProcessor.java
@@ -538,7 +538,6 @@ public class IgniteServiceProcessor extends ServiceProcessorAdapter implements I
* @param dfltNodeFilter Default NodeFilter.
* @return Configurations to deploy.
*/
- @SuppressWarnings("deprecation")
private PreparedConfigurations<IgniteUuid> prepareServiceConfigurations(Collection<ServiceConfiguration> cfgs,
IgnitePredicate<ClusterNode> dfltNodeFilter) {
List<ServiceConfiguration> cfgsCp = new ArrayList<>(cfgs.size());
@@ -1238,7 +1237,6 @@ public class IgniteServiceProcessor extends ServiceProcessorAdapter implements I
* @return Copy of service.
* @throws IgniteCheckedException If failed.
*/
- @SuppressWarnings("deprecation")
private Service copyAndInject(ServiceConfiguration cfg) throws IgniteCheckedException {
if (cfg instanceof LazyServiceConfiguration) {
byte[] bytes = ((LazyServiceConfiguration)cfg).serviceBytes();
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/service/ServiceDeploymentTask.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/service/ServiceDeploymentTask.java
index ea0114b..57f6616 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/service/ServiceDeploymentTask.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/service/ServiceDeploymentTask.java
@@ -283,7 +283,6 @@ class ServiceDeploymentTask {
/**
* @param depActions Services deployment actions.
*/
- @SuppressWarnings("ErrorNotRethrown")
private void processDeploymentActions(@NotNull ServiceDeploymentActions depActions) {
srvcProc.updateDeployedServices(depActions);
@@ -856,4 +855,4 @@ class ServiceDeploymentTask {
"locNodeId", (ctx != null ? ctx.localNodeId() : "unknown"),
"crdId", crdId);
}
-}
\ No newline at end of file
+}
diff --git a/modules/core/src/main/java/org/apache/ignite/plugin/PluginProvider.java b/modules/core/src/main/java/org/apache/ignite/plugin/PluginProvider.java
index 6aeb619..1914581 100644
--- a/modules/core/src/main/java/org/apache/ignite/plugin/PluginProvider.java
+++ b/modules/core/src/main/java/org/apache/ignite/plugin/PluginProvider.java
@@ -21,7 +21,6 @@ import java.io.Serializable;
import java.util.ServiceLoader;
import java.util.UUID;
import org.apache.ignite.IgniteCheckedException;
-import org.apache.ignite.IgniteCluster;
import org.apache.ignite.cluster.ClusterNode;
import org.apache.ignite.configuration.IgniteConfiguration;
import org.jetbrains.annotations.Nullable;
@@ -160,4 +159,4 @@ public interface PluginProvider<C extends PluginConfiguration> {
public default void validateNewNode(ClusterNode node, Serializable data) {
validateNewNode(node);
}
-}
\ No newline at end of file
+}
diff --git a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ipfinder/jdbc/JdbcIpFinderDialect.java b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ipfinder/jdbc/JdbcIpFinderDialect.java
index 099d172..50f36ff 100644
--- a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ipfinder/jdbc/JdbcIpFinderDialect.java
+++ b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ipfinder/jdbc/JdbcIpFinderDialect.java
@@ -20,9 +20,9 @@ package org.apache.ignite.spi.discovery.tcp.ipfinder.jdbc;
* SQL dialect to use with {@link TcpDiscoveryJdbcIpFinder}.
*/
public interface JdbcIpFinderDialect {
- /**
- * Gets table name in a valid form to use as IP addresses
- * @return Table name.
- */
- public String tableName();
+ /**
+ * Gets table name in a valid form to use as IP addresses
+ * @return Table name.
+ */
+ public String tableName();
}
diff --git a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ipfinder/jdbc/TcpDiscoveryJdbcIpFinder.java b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ipfinder/jdbc/TcpDiscoveryJdbcIpFinder.java
index fbbda07..0731a1b 100644
--- a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ipfinder/jdbc/TcpDiscoveryJdbcIpFinder.java
+++ b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ipfinder/jdbc/TcpDiscoveryJdbcIpFinder.java
@@ -99,11 +99,11 @@ public class TcpDiscoveryJdbcIpFinder extends TcpDiscoveryIpFinderAdapter {
* Constructor.
*/
public TcpDiscoveryJdbcIpFinder() {
- this(new BasicJdbcIpFinderDialect());
+ this(new BasicJdbcIpFinderDialect());
}
- public TcpDiscoveryJdbcIpFinder(JdbcIpFinderDialect jdbcDialect) {
- setShared(true);
+ public TcpDiscoveryJdbcIpFinder(JdbcIpFinderDialect jdbcDialect) {
+ setShared(true);
this.addrTableName = jdbcDialect.tableName();
this.getAddrsQry = "select hostname, port from " + addrTableName;
@@ -111,7 +111,7 @@ public class TcpDiscoveryJdbcIpFinder extends TcpDiscoveryIpFinderAdapter {
this.unregAddrQry = "delete from " + addrTableName + " where hostname = ? and port = ?";
this.createAddrsTableQry = "create table " + addrTableName + " (hostname VARCHAR(1024), port INT)";
this.chkQry = "select count(*) from " + addrTableName;
- }
+ }
/** {@inheritDoc} */
@Override public Collection<InetSocketAddress> getRegisteredAddresses() throws IgniteSpiException {
@@ -420,4 +420,4 @@ public class TcpDiscoveryJdbcIpFinder extends TcpDiscoveryIpFinderAdapter {
@Override public String toString() {
return S.toString(TcpDiscoveryJdbcIpFinder.class, this);
}
-}
\ No newline at end of file
+}
diff --git a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ipfinder/sharedfs/TcpDiscoverySharedFsIpFinder.java b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ipfinder/sharedfs/TcpDiscoverySharedFsIpFinder.java
index 7b41a6e..397af1a 100644
--- a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ipfinder/sharedfs/TcpDiscoverySharedFsIpFinder.java
+++ b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ipfinder/sharedfs/TcpDiscoverySharedFsIpFinder.java
@@ -28,7 +28,6 @@ import java.util.Set;
import java.util.StringTokenizer;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.atomic.AtomicBoolean;
-import org.apache.ignite.Ignite;
import org.apache.ignite.IgniteCheckedException;
import org.apache.ignite.IgniteLogger;
import org.apache.ignite.internal.IgniteInterruptedCheckedException;
@@ -37,7 +36,6 @@ import org.apache.ignite.internal.util.typedef.F;
import org.apache.ignite.internal.util.typedef.internal.S;
import org.apache.ignite.internal.util.typedef.internal.SB;
import org.apache.ignite.internal.util.typedef.internal.U;
-import org.apache.ignite.resources.IgniteInstanceResource;
import org.apache.ignite.resources.LoggerResource;
import org.apache.ignite.spi.IgniteSpiConfiguration;
import org.apache.ignite.spi.IgniteSpiException;
diff --git a/modules/core/src/main/java/org/apache/ignite/transactions/TransactionException.java b/modules/core/src/main/java/org/apache/ignite/transactions/TransactionException.java
index 484f6c5..d47fe08 100644
--- a/modules/core/src/main/java/org/apache/ignite/transactions/TransactionException.java
+++ b/modules/core/src/main/java/org/apache/ignite/transactions/TransactionException.java
@@ -42,40 +42,40 @@ import org.jetbrains.annotations.Nullable;
* {@link TransactionSerializationException} If operation performs within mvcc transaction and write conflict occurred.
*/
public class TransactionException extends IgniteException {
- /** Serial version UID. */
- private static final long serialVersionUID = 0L;
+ /** Serial version UID. */
+ private static final long serialVersionUID = 0L;
- /** Creates empty exception. */
- public TransactionException() {
- // No-op.
- }
+ /** Creates empty exception. */
+ public TransactionException() {
+ // No-op.
+ }
- /**
- * Creates new exception with given error message.
- *
- * @param msg Error message.
- */
- public TransactionException(String msg) {
- super(msg);
- }
+ /**
+ * Creates new exception with given error message.
+ *
+ * @param msg Error message.
+ */
+ public TransactionException(String msg) {
+ super(msg);
+ }
- /**
- * Creates new transaction exception with given throwable as a cause and
- * source of error message.
- *
- * @param cause Non-null throwable cause.
- */
- public TransactionException(Throwable cause) {
- super(cause);
- }
+ /**
+ * Creates new transaction exception with given throwable as a cause and
+ * source of error message.
+ *
+ * @param cause Non-null throwable cause.
+ */
+ public TransactionException(Throwable cause) {
+ super(cause);
+ }
- /**
- * Creates new exception with given error message and optional nested exception.
- *
- * @param msg Error message.
- * @param cause Optional nested exception (can be {@code null}).
- */
- public TransactionException(String msg, @Nullable Throwable cause) {
- super(msg, cause);
- }
-}
\ No newline at end of file
+ /**
+ * Creates new exception with given error message and optional nested exception.
+ *
+ * @param msg Error message.
+ * @param cause Optional nested exception (can be {@code null}).
+ */
+ public TransactionException(String msg, @Nullable Throwable cause) {
+ super(msg, cause);
+ }
+}
diff --git a/modules/core/src/test/java/org/apache/ignite/internal/ClusterNodeMetricsSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/ClusterNodeMetricsSelfTest.java
index 80c48ba..54937dc 100644
--- a/modules/core/src/test/java/org/apache/ignite/internal/ClusterNodeMetricsSelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/internal/ClusterNodeMetricsSelfTest.java
@@ -36,13 +36,11 @@ import org.apache.ignite.cache.eviction.fifo.FifoEvictionPolicy;
import org.apache.ignite.cluster.ClusterMetrics;
import org.apache.ignite.configuration.CacheConfiguration;
import org.apache.ignite.configuration.IgniteConfiguration;
-import org.apache.ignite.events.Event;
import org.apache.ignite.internal.processors.cache.persistence.DataRegion;
import org.apache.ignite.internal.processors.cache.persistence.DataRegionMetricsImpl;
import org.apache.ignite.internal.processors.task.GridInternal;
import org.apache.ignite.internal.util.lang.GridAbsPredicate;
import org.apache.ignite.internal.util.typedef.internal.U;
-import org.apache.ignite.lang.IgnitePredicate;
import org.apache.ignite.messaging.MessagingListenActor;
import org.apache.ignite.mxbean.ClusterMetricsMXBean;
import org.apache.ignite.testframework.GridTestUtils;
@@ -50,7 +48,6 @@ import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
import org.apache.ignite.testframework.junits.common.GridCommonTest;
import org.junit.Test;
-import static org.apache.ignite.events.EventType.EVT_NODE_METRICS_UPDATED;
import static org.apache.ignite.internal.IgniteNodeAttributes.ATTR_BUILD_VER;
import static org.apache.ignite.internal.IgniteNodeAttributes.ATTR_CLIENT_MODE;
import static org.apache.ignite.internal.IgniteVersionUtils.VER_STR;
diff --git a/modules/core/src/test/java/org/apache/ignite/internal/GridNonHistoryMetricsSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/GridNonHistoryMetricsSelfTest.java
index 5be55b5..010ed6a 100644
--- a/modules/core/src/test/java/org/apache/ignite/internal/GridNonHistoryMetricsSelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/internal/GridNonHistoryMetricsSelfTest.java
@@ -20,7 +20,6 @@ package org.apache.ignite.internal;
import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
-import java.util.concurrent.CountDownLatch;
import org.apache.ignite.GridTestJob;
import org.apache.ignite.Ignite;
import org.apache.ignite.IgniteLogger;
@@ -29,16 +28,12 @@ import org.apache.ignite.compute.ComputeJob;
import org.apache.ignite.compute.ComputeJobResult;
import org.apache.ignite.compute.ComputeTaskSplitAdapter;
import org.apache.ignite.configuration.IgniteConfiguration;
-import org.apache.ignite.events.Event;
import org.apache.ignite.internal.util.lang.GridAbsPredicate;
-import org.apache.ignite.lang.IgnitePredicate;
import org.apache.ignite.resources.LoggerResource;
import org.apache.ignite.testframework.GridTestUtils;
import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
import org.junit.Test;
-import static org.apache.ignite.events.EventType.EVT_NODE_METRICS_UPDATED;
-
/**
*
*/
diff --git a/modules/core/src/test/java/org/apache/ignite/internal/commandline/CommandArgFactory.java b/modules/core/src/test/java/org/apache/ignite/internal/commandline/CommandArgFactory.java
index 9a5b791..2ea98cd 100644
--- a/modules/core/src/test/java/org/apache/ignite/internal/commandline/CommandArgFactory.java
+++ b/modules/core/src/test/java/org/apache/ignite/internal/commandline/CommandArgFactory.java
@@ -17,7 +17,6 @@
package org.apache.ignite.internal.commandline;
-import java.util.Collections;
import org.apache.ignite.internal.commandline.argument.CommandArg;
import org.apache.ignite.internal.commandline.cache.CacheCommand;
import org.apache.ignite.internal.commandline.cache.argument.DistributionCommandArg;
diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheAbstractNodeRestartSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheAbstractNodeRestartSelfTest.java
index 89d0597..327c549 100644
--- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheAbstractNodeRestartSelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheAbstractNodeRestartSelfTest.java
@@ -42,8 +42,6 @@ import org.apache.ignite.configuration.CacheConfiguration;
import org.apache.ignite.configuration.IgniteConfiguration;
import org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi;
import org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi;
-import org.apache.ignite.spi.discovery.tcp.ipfinder.TcpDiscoveryIpFinder;
-import org.apache.ignite.spi.discovery.tcp.ipfinder.vm.TcpDiscoveryVmIpFinder;
import org.apache.ignite.testframework.GridTestUtils.SF;
import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
import org.apache.ignite.transactions.Transaction;
diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheLockAbstractTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheLockAbstractTest.java
index 827f84e..81dffd2 100644
--- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheLockAbstractTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/distributed/GridCacheLockAbstractTest.java
@@ -48,7 +48,6 @@ import static org.apache.ignite.cache.CacheWriteSynchronizationMode.FULL_ASYNC;
/**
* Test cases for multi-threaded tests.
*/
-@SuppressWarnings({"FieldCanBeLocal"})
public abstract class GridCacheLockAbstractTest extends GridCommonAbstractTest {
/** Grid1. */
private static Ignite ignite1;
diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/closure/GridClosureSerializationTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/closure/GridClosureSerializationTest.java
index 623ef9c..a809bf9 100644
--- a/modules/core/src/test/java/org/apache/ignite/internal/processors/closure/GridClosureSerializationTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/closure/GridClosureSerializationTest.java
@@ -101,7 +101,6 @@ public class GridClosureSerializationTest extends GridCommonAbstractTest {
/**
* @throws Exception If failed.
*/
- @SuppressWarnings({"Convert2Lambda"})
@Test
public void testAttributesSerializationFailure() throws Exception {
final IgniteEx ignite0 = grid(0);
diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsMetricsSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsMetricsSelfTest.java
index a60a363..e9191bb 100644
--- a/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsMetricsSelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsMetricsSelfTest.java
@@ -36,7 +36,6 @@ import org.apache.ignite.igfs.IgfsPath;
import org.apache.ignite.internal.util.typedef.G;
import org.apache.ignite.internal.util.typedef.internal.U;
import org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi;
-import org.apache.ignite.spi.discovery.tcp.ipfinder.TcpDiscoveryIpFinder;
import org.apache.ignite.spi.discovery.tcp.ipfinder.vm.TcpDiscoveryVmIpFinder;
import org.junit.Test;
diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsSizeSelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsSizeSelfTest.java
index f8ac37b..2aef9db 100644
--- a/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsSizeSelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/igfs/IgfsSizeSelfTest.java
@@ -48,9 +48,6 @@ import org.apache.ignite.internal.util.typedef.G;
import org.apache.ignite.internal.util.typedef.internal.U;
import org.apache.ignite.lang.IgniteInClosure;
import org.apache.ignite.lang.IgniteUuid;
-import org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi;
-import org.apache.ignite.spi.discovery.tcp.ipfinder.TcpDiscoveryIpFinder;
-import org.apache.ignite.spi.discovery.tcp.ipfinder.vm.TcpDiscoveryVmIpFinder;
import org.apache.ignite.testframework.GridTestUtils;
import org.junit.Test;
diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/service/GridServiceProcessorBatchDeploySelfTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/service/GridServiceProcessorBatchDeploySelfTest.java
index f122fde..9fec0e0 100644
--- a/modules/core/src/test/java/org/apache/ignite/internal/processors/service/GridServiceProcessorBatchDeploySelfTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/service/GridServiceProcessorBatchDeploySelfTest.java
@@ -39,7 +39,6 @@ import org.apache.ignite.services.ServiceDeploymentException;
import org.apache.ignite.services.ServiceDescriptor;
import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
import org.junit.Assume;
-import org.junit.Ignore;
import org.junit.Test;
import static org.apache.ignite.testframework.GridTestUtils.runAsync;
diff --git a/modules/core/src/test/java/org/apache/ignite/lang/GridBasicPerformanceTest.java b/modules/core/src/test/java/org/apache/ignite/lang/GridBasicPerformanceTest.java
index 97b8d2a..f120135 100644
--- a/modules/core/src/test/java/org/apache/ignite/lang/GridBasicPerformanceTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/lang/GridBasicPerformanceTest.java
@@ -801,7 +801,6 @@ public class GridBasicPerformanceTest {
/**
* @param q Queue.
*/
- @SuppressWarnings("StatementWithEmptyBody")
private static void testQueue(Queue<Integer> q) {
System.gc();
@@ -871,7 +870,6 @@ public class GridBasicPerformanceTest {
IgniteInternalFuture<?> fut2 = GridTestUtils.runMultiThreadedAsync(
new Callable<Object>() {
- @SuppressWarnings("StatementWithEmptyBody")
@Nullable @Override public Object call() throws Exception {
latch2.await();
@@ -1085,4 +1083,4 @@ public class GridBasicPerformanceTest {
return res;
}
}
-}
\ No newline at end of file
+}
diff --git a/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryReconnectUnstableTopologyTest.java b/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryReconnectUnstableTopologyTest.java
index 4576d33..c69280a 100644
--- a/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryReconnectUnstableTopologyTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/TcpDiscoveryReconnectUnstableTopologyTest.java
@@ -29,7 +29,6 @@ import org.apache.ignite.IgniteCheckedException;
import org.apache.ignite.cluster.ClusterNode;
import org.apache.ignite.configuration.CacheConfiguration;
import org.apache.ignite.configuration.IgniteConfiguration;
-import org.apache.ignite.events.EventType;
import org.apache.ignite.internal.DiscoverySpiTestListener;
import org.apache.ignite.internal.IgniteEx;
import org.apache.ignite.internal.IgniteInternalFuture;
diff --git a/modules/core/src/test/java/org/apache/ignite/testframework/junits/GridAbstractTest.java b/modules/core/src/test/java/org/apache/ignite/testframework/junits/GridAbstractTest.java
index b7798e0..3dc87c1 100755
--- a/modules/core/src/test/java/org/apache/ignite/testframework/junits/GridAbstractTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/testframework/junits/GridAbstractTest.java
@@ -146,8 +146,7 @@ import static org.apache.ignite.testframework.config.GridTestProperties.IGNITE_C
*/
@SuppressWarnings({
"TransientFieldInNonSerializableClass",
- "ProhibitedExceptionDeclared",
- "JUnitTestCaseWithNonTrivialConstructors"
+ "ProhibitedExceptionDeclared"
})
public abstract class GridAbstractTest extends JUnit3TestLegacySupport {
/**************************************************************
diff --git a/modules/core/src/test/java/org/apache/ignite/testframework/junits/spi/GridSpiAbstractTest.java b/modules/core/src/test/java/org/apache/ignite/testframework/junits/spi/GridSpiAbstractTest.java
index 0ba2837..d6741dd 100644
--- a/modules/core/src/test/java/org/apache/ignite/testframework/junits/spi/GridSpiAbstractTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/testframework/junits/spi/GridSpiAbstractTest.java
@@ -65,7 +65,6 @@ import static org.apache.ignite.lang.IgniteProductVersion.fromString;
* Base SPI test class.
* @param <T> SPI implementation class.
*/
-@SuppressWarnings({"JUnitTestCaseWithNonTrivialConstructors"})
public abstract class GridSpiAbstractTest<T extends IgniteSpi> extends GridAbstractTest {
/** */
private static final IgniteProductVersion VERSION = fromString("99.99.99");
diff --git a/modules/core/src/test/java/org/apache/ignite/testsuites/IgnitePdsTestSuite.java b/modules/core/src/test/java/org/apache/ignite/testsuites/IgnitePdsTestSuite.java
index e7b4462..046b7ff 100644
--- a/modules/core/src/test/java/org/apache/ignite/testsuites/IgnitePdsTestSuite.java
+++ b/modules/core/src/test/java/org/apache/ignite/testsuites/IgnitePdsTestSuite.java
@@ -56,7 +56,6 @@ import org.apache.ignite.internal.processors.database.IgniteDbPutGetWithCacheSto
import org.apache.ignite.internal.processors.database.IgniteDbSingleNodePutGetTest;
import org.apache.ignite.internal.processors.database.IgniteDbSingleNodeTinyPutGetTest;
import org.apache.ignite.internal.processors.metastorage.DistributedMetaStoragePersistentTest;
-import org.apache.ignite.internal.processors.metastorage.DistributedMetaStorageTest;
import org.apache.ignite.testframework.GridTestUtils;
import org.apache.ignite.testframework.junits.DynamicSuite;
import org.junit.runner.RunWith;