(incubator-devlake) branch kw-7021-unable-to-trigger-projects-with-webhooks-only updated (287446baa -> b00d3de85)

[kl...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

klesh pushed a change to branch kw-7021-unable-to-trigger-projects-with-webhooks-only
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git


 discard 287446baa fix: unable to trigger blueprints with webhooks only
    omit b5ddbb972 fix: blueprint gets disabled when disabling dora for project
     add 3ad9aaff2 fix: blueprint gets disabled when disabling dora for project (#7146)
     new b00d3de85 fix: unable to trigger blueprints with webhooks only

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (287446baa)
            \
             N -- N -- N   refs/heads/kw-7021-unable-to-trigger-projects-with-webhooks-only (b00d3de85)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:

(incubator-devlake) 01/01: fix: unable to trigger blueprints with webhooks only

[kl...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

klesh pushed a commit to branch kw-7021-unable-to-trigger-projects-with-webhooks-only
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git

commit b00d3de85a59f91b731722a92ea01373818555c8
Author: Klesh Wong <zh...@merico.dev>
AuthorDate: Fri Mar 8 16:39:26 2024 +0800

    fix: unable to trigger blueprints with webhooks only
---
 backend/server/services/blueprint.go | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/backend/server/services/blueprint.go b/backend/server/services/blueprint.go
index 8e693ab11..2f7ddb51a 100644
--- a/backend/server/services/blueprint.go
+++ b/backend/server/services/blueprint.go
@@ -320,21 +320,21 @@ func createPipelineByBlueprint(blueprint *models.Blueprint, syncPolicy *models.S
 	newPipeline.SyncPolicy = blueprint.SyncPolicy
 
 	// if the plan is empty, we should not create the pipeline
-	var shouldCreatePipeline bool
-	for _, stage := range plan {
-		for _, task := range stage {
-			switch task.Plugin {
-			case "org", "refdiff", "dora":
-			default:
-				if !plan.IsEmpty() {
-					shouldCreatePipeline = true
-				}
-			}
-		}
-	}
-	if !shouldCreatePipeline {
-		return nil, ErrEmptyPlan
-	}
+	// var shouldCreatePipeline bool
+	// for _, stage := range plan {
+	// 	for _, task := range stage {
+	// 		switch task.Plugin {
+	// 		case "org", "refdiff", "dora":
+	// 		default:
+	// 			if !plan.IsEmpty() {
+	// 				shouldCreatePipeline = true
+	// 			}
+	// 		}
+	// 	}
+	// }
+	// if !shouldCreatePipeline {
+	// 	return nil, ErrEmptyPlan
+	// }
 	pipeline, err := CreatePipeline(&newPipeline, false)
 	// Return all created tasks to the User
 	if err != nil {