You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/16 01:51:58 UTC
[GitHub] [shardingsphere] isHuangXin opened a new pull request, #22193: test(issue-21464): ShowShardingHintStatusStatement
isHuangXin opened a new pull request, #22193:
URL: https://github.com/apache/shardingsphere/pull/22193
For #21464.
Changes proposed in this pull request:
- Add test unit for ShowShardingHintStatusStatement.
- Rename readwrite-splitting hint status
Particularly Notes: SQL statement `<show-sharding-hint-status sql-case-id="show-sharding-hint-status" />` has already been in the XML file `hint.xml`
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #22193: test(issue-21464): ShowShardingHintStatusStatement
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #22193:
URL: https://github.com/apache/shardingsphere/pull/22193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22193: test(issue-21464): ShowShardingHintStatusStatement
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22193:
URL: https://github.com/apache/shardingsphere/pull/22193#issuecomment-1316211620
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22193?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22193](https://codecov.io/gh/apache/shardingsphere/pull/22193?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b961f64) into [master](https://codecov.io/gh/apache/shardingsphere/commit/3719f6e5c8a52b08aa09c74b28c346422f2386d4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3719f6e) will **increase** coverage by `0.00%`.
> The diff coverage is `66.66%`.
```diff
@@ Coverage Diff @@
## master #22193 +/- ##
=========================================
Coverage 60.98% 60.99%
- Complexity 2548 2550 +2
=========================================
Files 4124 4125 +1
Lines 57467 57473 +6
Branches 9734 9735 +1
=========================================
+ Hits 35049 35055 +6
+ Misses 19456 19454 -2
- Partials 2962 2964 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...owReadwriteSplittingHintStatusStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/22193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9pbnRlcm5hbC9hc3NlcnRzL3N0YXRlbWVudC9kaXN0c3FsL3JhbC9pbXBsL2hpbnQvU2hvd1JlYWR3cml0ZVNwbGl0dGluZ0hpbnRTdGF0dXNTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `50.00% <ø> (ø)` | |
| [...pl/hint/ShowShardingHintStatusStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/22193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9pbnRlcm5hbC9hc3NlcnRzL3N0YXRlbWVudC9kaXN0c3FsL3JhbC9pbXBsL2hpbnQvU2hvd1NoYXJkaW5nSGludFN0YXR1c1N0YXRlbWVudEFzc2VydC5qYXZh) | `50.00% <50.00%> (ø)` | |
| [...ement/distsql/ral/impl/HintRALStatementAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/22193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9pbnRlcm5hbC9hc3NlcnRzL3N0YXRlbWVudC9kaXN0c3FsL3JhbC9pbXBsL0hpbnRSQUxTdGF0ZW1lbnRBc3NlcnQuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ommand/query/text/MySQLTextResultSetRowPacket.java](https://codecov.io/gh/apache/shardingsphere/pull/22193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGItcHJvdG9jb2wvbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9jb21tYW5kL3F1ZXJ5L3RleHQvTXlTUUxUZXh0UmVzdWx0U2V0Um93UGFja2V0LmphdmE=) | `83.33% <0.00%> (-4.17%)` | :arrow_down: |
| [...handler/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/22193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `42.85% <0.00%> (+42.85%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org