You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by anthonycorbacho <gi...@git.apache.org> on 2016/11/03 12:22:12 UTC

[GitHub] zeppelin pull request #1591: Fix latency on notebook save in ZeppelinHubNote...

GitHub user anthonycorbacho opened a pull request:

    https://github.com/apache/zeppelin/pull/1591

    Fix latency on notebook save in ZeppelinHubNotebookRepo

    ### What is this PR for?
    Fix latency issue when user save a notebook while using zeppelinhub notebook storage.
    
    ### What type of PR is it?
    [Improvement]
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anthonycorbacho/incubator-zeppelin feat/ZeppelinHubRepoSaveNoteShouldNotBlock

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1591.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1591
    
----
commit 06d70607d54dab4fc9f9206ee4c9e8e7ffe83c5e
Author: Anthony Corbacho <co...@gmail.com>
Date:   2016-11-03T12:19:12Z

    Fix latency on notebook save in ZeppelinHubNotebookRepo
    
    (cherry picked from commit 50d57d2e4e6fdd4123bf105adc8896dd62c599d5)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1591: Fix latency on notebook save in ZeppelinHubNotebookRep...

Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the issue:

    https://github.com/apache/zeppelin/pull/1591
  
    travis is super slow today
    
    Amerika is working to hard today :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1591: [WIP] Fix latency on notebook save in ZeppelinHubNoteb...

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1591
  
    Looks great to me, thank you for fix and prompt response! 
    
    Let's merge after CI is green, if there is no further discussions. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1591: [WIP] Fix latency on notebook save in ZeppelinHubNoteb...

Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/1591
  
    @anthonycorbacho Thanks for bringing back async nature for note saves, LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1591: [ZEPPELIN-1627] - Fix latency on notebook save ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1591


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1591: Fix latency on notebook save in ZeppelinHubNotebookRep...

Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the issue:

    https://github.com/apache/zeppelin/pull/1591
  
    CI is failing due to `testEditOnDoubleClick`, and it is not related to this PR.
    
    So i am merging it :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---