You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@ip-10-146-233-104.ec2.internal> on 2016/02/03 23:02:04 UTC
[kudu-CR] [c++ client] - Expose the schema being scanned in KuduScanBatch
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/2020
to review the following change.
Change subject: [c++ client] - Expose the schema being scanned in KuduScanBatch
......................................................................
[c++ client] - Expose the schema being scanned in KuduScanBatch
This exposes the schema being scanned in the KuduScanBatch and KuduScanBatch::RowPtr
allowing to pass pointer/references to these around when in use without an accompanying
schema, which was hard to infer in any case since the scanner projection is set with
just column names.
Note that this is just exposing the schema information that was already there, just
in KuduSchema form (vs. the internal Schema) which is more suited for user consumption.
Change-Id: Id4276036d5ba7faf7959b4324fd013b68a08bec5
---
M src/kudu/client/client-test-util.cc
M src/kudu/client/client-test-util.h
M src/kudu/client/client.cc
M src/kudu/client/scan_batch.cc
M src/kudu/client/scan_batch.h
M src/kudu/client/scanner-internal.cc
M src/kudu/client/scanner-internal.h
M src/kudu/client/schema.h
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/integration-tests/remote_bootstrap-itest.cc
M src/kudu/integration-tests/test_workload.cc
M src/kudu/integration-tests/ts_itest-base.h
M src/kudu/tools/ts-cli.cc
14 files changed, 58 insertions(+), 26 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/2020/1
--
To view, visit http://gerrit.cloudera.org:8080/2020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id4276036d5ba7faf7959b4324fd013b68a08bec5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <da...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>