You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "ruanwenjun (via GitHub)" <gi...@apache.org> on 2025/11/27 02:02:59 UTC
[PR] [Fix-17732] Change workflow instance status to failure when command handle failed [dolphinscheduler]
ruanwenjun opened a new pull request, #17745:
URL: https://github.com/apache/dolphinscheduler/pull/17745
## Purpose of the pull request
related issue #17732
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
## Pull Request Notice
[Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
If your pull request contains incompatible change, you should also add it to `docs/docs/en/guide/upgrade/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-17732] Change workflow instance status to failure when command handle failed [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17745:
URL: https://github.com/apache/dolphinscheduler/pull/17745#issuecomment-3588325291
Please retry analysis of this Pull-Request directly on SonarQube Cloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-17732] Change workflow instance status to failure when command handle failed [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17745:
URL: https://github.com/apache/dolphinscheduler/pull/17745#issuecomment-3596320898
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745) **Quality Gate passed**
Issues
 [3 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17745&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=17745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [80.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17745&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17745&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-17732] Change workflow instance status to failure when command handle failed [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17745:
URL: https://github.com/apache/dolphinscheduler/pull/17745#issuecomment-3591466793
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745) **Quality Gate passed**
Issues
 [3 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17745&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=17745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [80.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17745&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17745&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-17732] Change workflow instance status to failure when command handle failed [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17745:
URL: https://github.com/apache/dolphinscheduler/pull/17745#issuecomment-3591579407
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745) **Quality Gate passed**
Issues
 [3 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17745&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=17745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [80.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17745&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17745&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-17732] Change workflow instance status to failure when command handle failed [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17745:
URL: https://github.com/apache/dolphinscheduler/pull/17745#issuecomment-3591468196
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745) **Quality Gate passed**
Issues
 [3 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17745&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=17745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [80.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17745&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17745&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-17732] Change workflow instance status to failure when command handle failed [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS merged PR #17745:
URL: https://github.com/apache/dolphinscheduler/pull/17745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-17732] Change workflow instance status to failure when command handle failed [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17745:
URL: https://github.com/apache/dolphinscheduler/pull/17745#issuecomment-3583998367
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745) **Quality Gate failed**
Failed conditions
 [44.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17745&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-17732] Change workflow instance status to failure when command handle failed [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17745:
URL: https://github.com/apache/dolphinscheduler/pull/17745#issuecomment-3591575970
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745) **Quality Gate passed**
Issues
 [3 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17745&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=17745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [80.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17745&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17745&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-17732] Change workflow instance status to failure when command handle failed [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17745:
URL: https://github.com/apache/dolphinscheduler/pull/17745#issuecomment-3586551959
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745) **Quality Gate failed**
Failed conditions
 [43.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17745&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-17732] Change workflow instance status to failure when command handle failed [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17745:
URL: https://github.com/apache/dolphinscheduler/pull/17745#issuecomment-3586544860
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745) **Quality Gate failed**
Failed conditions
 [43.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17745&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-17732] Change workflow instance status to failure when command handle failed [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17745:
URL: https://github.com/apache/dolphinscheduler/pull/17745#issuecomment-3584000519
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745) **Quality Gate failed**
Failed conditions
 [44.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17745&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-17732] Change workflow instance status to failure when command handle failed [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17745:
URL: https://github.com/apache/dolphinscheduler/pull/17745#issuecomment-3585818051
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745) **Quality Gate failed**
Failed conditions
 [43.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17745&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-17732] Change workflow instance status to failure when command handle failed [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17745:
URL: https://github.com/apache/dolphinscheduler/pull/17745#issuecomment-3588325263
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745) **Quality Gate failed**
Failed conditions
 [43.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17745&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-17732] Change workflow instance status to failure when command handle failed [dolphinscheduler]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #17745:
URL: https://github.com/apache/dolphinscheduler/pull/17745#discussion_r2567444397
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/WorkflowInstanceMapper.java:
##########
@@ -138,6 +138,9 @@ int updateWorkflowInstanceState(
@Param("originState") WorkflowExecutionStatus originState,
@Param("targetState") WorkflowExecutionStatus targetState);
+ int forceUpdateWorkflowInstanceState(Integer workflowInstanceId,
Review Comment:
The `workflowInstanceId` parameter is missing the `@Param` annotation. All MyBatis mapper method parameters in this codebase consistently use `@Param` annotations, as seen in other methods like `updateWorkflowInstanceState`. Add `@Param("workflowInstanceId")` to maintain consistency and ensure proper MyBatis parameter mapping.
```java
int forceUpdateWorkflowInstanceState(@Param("workflowInstanceId") Integer workflowInstanceId,
@Param("targetState") WorkflowExecutionStatus targetState);
```
```suggestion
int forceUpdateWorkflowInstanceState(@Param("workflowInstanceId") Integer workflowInstanceId,
```
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/graph/WorkflowGraph.java:
##########
@@ -46,12 +45,20 @@ public WorkflowGraph(List<WorkflowTaskRelation> workflowTaskRelations, List<Task
this.predecessors = new HashMap<>();
this.successors = new HashMap<>();
- this.taskDefinitionMap = taskDefinitions
- .stream()
- .collect(Collectors.toMap(TaskDefinition::getName, Function.identity()));
- this.taskDefinitionCodeMap = taskDefinitions
- .stream()
- .collect(Collectors.toMap(TaskDefinition::getCode, Function.identity()));
+ this.taskDefinitionMap = new HashMap<>(taskDefinitions.size());
+ this.taskDefinitionCodeMap = new HashMap<>(taskDefinitions.size());
+ for (TaskDefinition taskDefinition : taskDefinitions) {
+ if (taskDefinitionMap.containsKey(taskDefinition.getName())) {
+ throw new IllegalArgumentException(
+ "Duplicate task name: " + taskDefinition.getName() + " in the workflow");
+ }
+ taskDefinitionMap.put(taskDefinition.getName(), taskDefinition);
+ if (taskDefinitionCodeMap.containsKey(taskDefinition.getCode())) {
+ throw new IllegalArgumentException(
+ "Duplicate task code: " + taskDefinition.getCode() + " in the workflow");
+ }
+ taskDefinitionCodeMap.put(taskDefinition.getCode(), taskDefinition);
+ }
Review Comment:
The new duplicate detection logic for task names and codes lacks test coverage. Consider adding test cases to verify that:
1. An `IllegalArgumentException` is thrown when duplicate task names are provided
2. An `IllegalArgumentException` is thrown when duplicate task codes are provided
This validation is important for data integrity and should be tested to prevent regressions.
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/command/CommandEngine.java:
##########
@@ -189,8 +193,15 @@ private Void bootstrapError(Command command, Throwable throwable) {
throwable);
return null;
}
- log.error("Failed bootstrap command {} ", JSONUtils.toPrettyJsonString(command), throwable);
+
+ log.warn("Failed bootstrap command {} ", JSONUtils.toPrettyJsonString(command), throwable);
+
+ workflowInstanceDao.forceUpdateWorkflowInstanceState(command.getWorkflowInstanceId(),
+ WorkflowExecutionStatus.FAILURE);
+ log.info("Set workflow instance {} state to FAILURE", command.getWorkflowInstanceId());
+
commandService.moveToErrorCommand(command, ExceptionUtils.getStackTrace(throwable));
+ log.info("Move command {} to error command table", command.getId());
Review Comment:
Potential race condition: the workflow instance state update (line 199-200) and command deletion (line 203) are not within the same transaction. If the application crashes between these operations, the workflow instance may be marked as FAILURE but the command remains in the command table instead of being moved to the error command table. Consider wrapping both operations in a single transaction, or ensure the `moveToErrorCommand` method's transaction also includes the workflow instance state update.
##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/repository/impl/WorkflowInstanceDaoImpl.java:
##########
@@ -75,6 +75,11 @@ public void updateWorkflowInstanceState(Integer workflowInstanceId, WorkflowExec
}
}
+ @Override
+ public void forceUpdateWorkflowInstanceState(Integer workflowInstanceId, WorkflowExecutionStatus targetState) {
+ mybatisMapper.forceUpdateWorkflowInstanceState(workflowInstanceId, targetState);
+ }
Review Comment:
The `forceUpdateWorkflowInstanceState` method lacks test coverage. Since `WorkflowInstanceDaoImplTest` already exists with tests for `updateWorkflowInstanceState` (lines 71-97), consider adding a test case for this new method to verify it correctly updates the workflow instance state without checking the original state, ensuring the "force update" behavior is properly tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-17732] Change workflow instance status to failure when command handle failed [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17745:
URL: https://github.com/apache/dolphinscheduler/pull/17745#issuecomment-3585800742
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745) **Quality Gate failed**
Failed conditions
 [43.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17745&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix-17732] Change workflow instance status to failure when command handle failed [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17745:
URL: https://github.com/apache/dolphinscheduler/pull/17745#issuecomment-3596308213
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745) **Quality Gate passed**
Issues
 [3 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17745&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=17745&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [80.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17745&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17745&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17745)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org