[GitHub] [arrow] westonpace commented on a diff in pull request #36566: GH-30717: [C#] Add ToString() methods to Arrow classes

["westonpace (via GitHub)" <gi...@apache.org>]

westonpace commented on code in PR #36566:
URL: https://github.com/apache/arrow/pull/36566#discussion_r1265717767


##########
csharp/src/Apache.Arrow/RecordBatch.cs:
##########
@@ -93,5 +93,7 @@ public RecordBatch Clone(MemoryAllocator allocator = default)
             IEnumerable<IArrowArray> arrays = _arrays.Select(array => ArrowArrayFactory.BuildArray(array.Data.Clone(allocator)));
             return new RecordBatch(Schema, arrays, Length);
         }
+
+        public override string ToString() => $"{nameof(RecordBatch)}: Length={Length}, ColumnCount={ColumnCount}";

Review Comment:
   Could this be `{ColumnCount} columns by {RowCount} rows` for consistency with `Table`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org