[GitHub] [superset] hughhhh commented on a diff in pull request #21971: refactor: use exception status for logging

[GitBox <gi...@apache.org>]

hughhhh commented on code in PR #21971:
URL: https://github.com/apache/superset/pull/21971#discussion_r1022135926


##########
superset/reports/commands/exceptions.py:
##########
@@ -258,6 +261,17 @@ class ReportScheduleStateNotFoundError(CommandException):
     message = _("Report Schedule state not found")
 
 
+class ReportScheduleSystemErrorsException(CommandException, SupersetErrorsException):
+    errors: List[SupersetError] = []

Review Comment:
   Do we want to set an overall status for the array or do we want  to do it based upon the most critical error in the error array



##########
superset/reports/commands/exceptions.py:
##########
@@ -258,6 +261,17 @@ class ReportScheduleStateNotFoundError(CommandException):
     message = _("Report Schedule state not found")
 
 
+class ReportScheduleSystemErrorsException(CommandException, SupersetErrorsException):
+    errors: List[SupersetError] = []
+    message = _("Report schedule system error")
+
+
+class ReportScheduleClientErrorsException(CommandException, SupersetErrorsException):
+    status = 400

Review Comment:
   Here we have a status but the exception above doesn't 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org