You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "jonathanc-n (via GitHub)" <gi...@apache.org> on 2024/10/22 00:19:24 UTC
[I] Add regexp function - regexp_matches() [datafusion]
jonathanc-n opened a new issue, #13052:
URL: https://github.com/apache/datafusion/issues/13052
### Is your feature request related to a problem or challenge?
_No response_
### Describe the solution you'd like
regexp_match() is already implemented, so we just need to look into building on that.
### Describe alternatives you've considered
_No response_
### Additional context
Discussed in #11946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Add regexp function - regexp_matches() [datafusion]
Posted by "jonathanc-n (via GitHub)" <gi...@apache.org>.
jonathanc-n commented on issue #13052:
URL: https://github.com/apache/datafusion/issues/13052#issuecomment-2439685475
@jcsherin Sorry, a little new to the arrow/datafusion ecosystem. If i want to add a regexp_matches implementation, would i have to push that to arrow, and wait for the next version to come out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Add regexp function - regexp_matches() [datafusion]
Posted by "jcsherin (via GitHub)" <gi...@apache.org>.
jcsherin commented on issue #13052:
URL: https://github.com/apache/datafusion/issues/13052#issuecomment-2436820861
Yes, it should be possible to share code between `regexp_match` and `regexp_matches` as they are similar in functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Add regexp function - regexp_matches() [datafusion]
Posted by "jonathanc-n (via GitHub)" <gi...@apache.org>.
jonathanc-n commented on issue #13052:
URL: https://github.com/apache/datafusion/issues/13052#issuecomment-2427985664
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Add regexp function - regexp_matches() [datafusion]
Posted by "jonathanc-n (via GitHub)" <gi...@apache.org>.
jonathanc-n commented on issue #13052:
URL: https://github.com/apache/datafusion/issues/13052#issuecomment-2436685008
@jcsherin Do you think it'd be preferred to have regexp_matches on the same page as regexp_match or should i create a new file for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Add regexp function - regexp_matches() [datafusion]
Posted by "jcsherin (via GitHub)" <gi...@apache.org>.
jcsherin commented on issue #13052:
URL: https://github.com/apache/datafusion/issues/13052#issuecomment-2439708731
I think it is easier (less friction) to first, get something working here (with docs, test coverage) and iterate quickly over feedback from other contributors. Then it will become evident which parts are better moved upstream to arrow. So you can get this working completely here.
If you run into any roadblocks, more experienced (not me) contributors will help you out 🤝
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Add regexp function - regexp_matches() [datafusion]
Posted by "jonathanc-n (via GitHub)" <gi...@apache.org>.
jonathanc-n commented on issue #13052:
URL: https://github.com/apache/datafusion/issues/13052#issuecomment-2439658048
I was thinking that it may be better for regexp_matches to be in a separate file as it would probably just be easier to maintain + matches introduces some additional complications to implementation. It would've probably been easier to have created the regexp_matches then implement match afterwards on top of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org