You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Matt Marum <mg...@us.ibm.com> on 2011/12/13 17:04:45 UTC
Review Request: Add support for Embedded Experience Gadgets in the
CommonContainer test environment
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
This has makes quickly testing EE gadgets much easier.
This addresses bug SHINDIG-1675.
https://issues.apache.org/jira/browse/SHINDIG-1675
Diffs
-----
/trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1213743
/trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1213743
/trunk/content/samplecontainer/examples/commoncontainer/index.html 1213743
/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1213743
Diff: https://reviews.apache.org/r/3165/diff
Testing
-------
Tested locally with some EE gadgets I've been building. Andy Smith has used it too. There are no automated tests for the sample containers.
Thanks,
Matt
Re: Review Request: Add support for Embedded Experience Gadgets in the
CommonContainer test environment
Posted by Matt Marum <mg...@us.ibm.com>.
> On 2011-12-20 14:00:30, Ryan Baxter wrote:
> > /trunk/content/samplecontainer/examples/commoncontainer/viewController.js, line 207
> > <https://reviews.apache.org/r/3165/diff/2/?file=64332#file64332line207>
> >
> > I believe jQuery provides a function that we can use instead of eval
The jQuery eval function that I found was..
http://api.jquery.com/jQuery.globalEval/
>From the doc..
"This method behaves differently from using a normal JavaScript eval() in that it's executed within the global context (which is important for loading external scripts dynamically)."
In this case, I'm not sure if it is necessary or even desirable to allow the user input to run within the global context but I'm still a mostly novice JavaScript programmer so I can be easily convinced otherwise. Unless it does some input sanitizing or something.
- Matt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/#review4011
-----------------------------------------------------------
On 2011-12-21 16:05:37, Matt Marum wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3165/
> -----------------------------------------------------------
>
> (Updated 2011-12-21 16:05:37)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
>
> This has makes quickly testing EE gadgets much easier.
>
>
> This addresses bug SHINDIG-1675.
> https://issues.apache.org/jira/browse/SHINDIG-1675
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1220905
> /trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1220905
> /trunk/content/samplecontainer/examples/commoncontainer/index.html 1220905
> /trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1220905
>
> Diff: https://reviews.apache.org/r/3165/diff
>
>
> Testing
> -------
>
> Tested locally with some EE gadgets I've been building. Andy Smith has used it too. There are no automated tests for the sample containers.
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request: Add support for Embedded Experience Gadgets in the
CommonContainer test environment
Posted by Ryan Baxter <rb...@gmail.com>.
> On 2011-12-20 14:00:30, Ryan Baxter wrote:
> > /trunk/content/samplecontainer/examples/commoncontainer/viewController.js, line 207
> > <https://reviews.apache.org/r/3165/diff/2/?file=64332#file64332line207>
> >
> > I believe jQuery provides a function that we can use instead of eval
>
> Matt Marum wrote:
> The jQuery eval function that I found was..
>
> http://api.jquery.com/jQuery.globalEval/
>
> From the doc..
> "This method behaves differently from using a normal JavaScript eval() in that it's executed within the global context (which is important for loading external scripts dynamically)."
>
> In this case, I'm not sure if it is necessary or even desirable to allow the user input to run within the global context but I'm still a mostly novice JavaScript programmer so I can be easily convinced otherwise. Unless it does some input sanitizing or something.
Now that I am thinking about this you should be able to use gadgets.json.parse
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/#review4011
-----------------------------------------------------------
On 2011-12-21 16:05:37, Matt Marum wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3165/
> -----------------------------------------------------------
>
> (Updated 2011-12-21 16:05:37)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
>
> This has makes quickly testing EE gadgets much easier.
>
>
> This addresses bug SHINDIG-1675.
> https://issues.apache.org/jira/browse/SHINDIG-1675
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1220905
> /trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1220905
> /trunk/content/samplecontainer/examples/commoncontainer/index.html 1220905
> /trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1220905
>
> Diff: https://reviews.apache.org/r/3165/diff
>
>
> Testing
> -------
>
> Tested locally with some EE gadgets I've been building. Andy Smith has used it too. There are no automated tests for the sample containers.
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request: Add support for Embedded Experience Gadgets in the
CommonContainer test environment
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/#review4011
-----------------------------------------------------------
Matt there is some good cleanup here, thanks! I am just wondering whether it makes sense to have this functionality added to the embedded experience sample container that is already part of Shindig? What do you think....
/trunk/content/samplecontainer/examples/commoncontainer/viewController.js
<https://reviews.apache.org/r/3165/#comment9083>
Looks like there is some spacing problems here
/trunk/content/samplecontainer/examples/commoncontainer/viewController.js
<https://reviews.apache.org/r/3165/#comment9084>
I believe jQuery provides a function that we can use instead of eval
/trunk/content/samplecontainer/examples/commoncontainer/viewController.js
<https://reviews.apache.org/r/3165/#comment9085>
It might be worth also specifying height and width for URL Rendar Params
- Ryan
On 2011-12-13 16:04:45, Matt Marum wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3165/
> -----------------------------------------------------------
>
> (Updated 2011-12-13 16:04:45)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
>
> This has makes quickly testing EE gadgets much easier.
>
>
> This addresses bug SHINDIG-1675.
> https://issues.apache.org/jira/browse/SHINDIG-1675
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1213743
> /trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1213743
> /trunk/content/samplecontainer/examples/commoncontainer/index.html 1213743
> /trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1213743
>
> Diff: https://reviews.apache.org/r/3165/diff
>
>
> Testing
> -------
>
> Tested locally with some EE gadgets I've been building. Andy Smith has used it too. There are no automated tests for the sample containers.
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request: Add support for Embedded Experience Gadgets in the
CommonContainer test environment
Posted by Matt Marum <mg...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/#review4040
-----------------------------------------------------------
/trunk/content/samplecontainer/examples/commoncontainer/viewController.js
<https://reviews.apache.org/r/3165/#comment9145>
Will do.
- Matt
On 2011-12-21 16:05:37, Matt Marum wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3165/
> -----------------------------------------------------------
>
> (Updated 2011-12-21 16:05:37)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
>
> This has makes quickly testing EE gadgets much easier.
>
>
> This addresses bug SHINDIG-1675.
> https://issues.apache.org/jira/browse/SHINDIG-1675
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1220905
> /trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1220905
> /trunk/content/samplecontainer/examples/commoncontainer/index.html 1220905
> /trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1220905
>
> Diff: https://reviews.apache.org/r/3165/diff
>
>
> Testing
> -------
>
> Tested locally with some EE gadgets I've been building. Andy Smith has used it too. There are no automated tests for the sample containers.
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request: Add support for Embedded Experience Gadgets in the
CommonContainer test environment
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/#review4240
-----------------------------------------------------------
/trunk/content/samplecontainer/examples/commoncontainer/index.html
<https://reviews.apache.org/r/3165/#comment9592>
You probably want to wrap these label - input element combinations in divs or but breaks inbetween them. If the screen is wide enough the labels end up not being on the same line as the input fields.
- Ryan
On 2011-12-21 17:24:41, Matt Marum wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3165/
> -----------------------------------------------------------
>
> (Updated 2011-12-21 17:24:41)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
>
> This has makes quickly testing EE gadgets much easier.
>
>
> This addresses bug SHINDIG-1675.
> https://issues.apache.org/jira/browse/SHINDIG-1675
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1220905
> /trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1220905
> /trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1220905
> /trunk/content/samplecontainer/examples/commoncontainer/index.html 1220905
>
> Diff: https://reviews.apache.org/r/3165/diff
>
>
> Testing
> -------
>
> Tested locally with some EE gadgets I've been building. Andy Smith has used it too. There are no automated tests for the sample containers.
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request: Add support for Embedded Experience Gadgets in the
CommonContainer test environment
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/#review4265
-----------------------------------------------------------
Ship it!
Removed extra white space and committed. Thanks Matt!
Committed revision 1229170.
- Ryan
On 2012-01-08 23:08:29, Matt Marum wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3165/
> -----------------------------------------------------------
>
> (Updated 2012-01-08 23:08:29)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
>
> This has makes quickly testing EE gadgets much easier.
>
>
> This addresses bug SHINDIG-1675.
> https://issues.apache.org/jira/browse/SHINDIG-1675
>
>
> Diffs
> -----
>
> /trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1228330
> /trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1228330
> /trunk/content/samplecontainer/examples/commoncontainer/index.html 1228330
> /trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1228330
>
> Diff: https://reviews.apache.org/r/3165/diff
>
>
> Testing
> -------
>
> Tested locally with some EE gadgets I've been building. Andy Smith has used it too. There are no automated tests for the sample containers.
>
>
> Thanks,
>
> Matt
>
>
Re: Review Request: Add support for Embedded Experience Gadgets in the
CommonContainer test environment
Posted by Matt Marum <mg...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/
-----------------------------------------------------------
(Updated 2012-01-08 23:08:29.278791)
Review request for shindig.
Changes
-------
Fixed HTML layout.
Summary
-------
As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
This has makes quickly testing EE gadgets much easier.
This addresses bug SHINDIG-1675.
https://issues.apache.org/jira/browse/SHINDIG-1675
Diffs (updated)
-----
/trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1228330
/trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1228330
/trunk/content/samplecontainer/examples/commoncontainer/index.html 1228330
/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1228330
Diff: https://reviews.apache.org/r/3165/diff
Testing
-------
Tested locally with some EE gadgets I've been building. Andy Smith has used it too. There are no automated tests for the sample containers.
Thanks,
Matt
Re: Review Request: Add support for Embedded Experience Gadgets in the
CommonContainer test environment
Posted by Matt Marum <mg...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/
-----------------------------------------------------------
(Updated 2011-12-21 17:24:41.770174)
Review request for shindig.
Changes
-------
Using gadgets.json.parse now.
Summary
-------
As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
This has makes quickly testing EE gadgets much easier.
This addresses bug SHINDIG-1675.
https://issues.apache.org/jira/browse/SHINDIG-1675
Diffs (updated)
-----
/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1220905
/trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1220905
/trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1220905
/trunk/content/samplecontainer/examples/commoncontainer/index.html 1220905
Diff: https://reviews.apache.org/r/3165/diff
Testing
-------
Tested locally with some EE gadgets I've been building. Andy Smith has used it too. There are no automated tests for the sample containers.
Thanks,
Matt
Re: Review Request: Add support for Embedded Experience Gadgets in the
CommonContainer test environment
Posted by Matt Marum <mg...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/
-----------------------------------------------------------
(Updated 2011-12-21 16:05:37.642013)
Review request for shindig.
Changes
-------
Added support for setting embedded experience gadget height/width in test page.
Summary
-------
As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
This has makes quickly testing EE gadgets much easier.
This addresses bug SHINDIG-1675.
https://issues.apache.org/jira/browse/SHINDIG-1675
Diffs (updated)
-----
/trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1220905
/trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1220905
/trunk/content/samplecontainer/examples/commoncontainer/index.html 1220905
/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1220905
Diff: https://reviews.apache.org/r/3165/diff
Testing
-------
Tested locally with some EE gadgets I've been building. Andy Smith has used it too. There are no automated tests for the sample containers.
Thanks,
Matt