You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/28 05:29:52 UTC
[GitHub] [spark] grundprinzip commented on a diff in pull request #39252: [SPARK-41734][CONNECT] Add a parent message for Catalog
grundprinzip commented on code in PR #39252:
URL: https://github.com/apache/spark/pull/39252#discussion_r1058067556
##########
connector/connect/common/src/main/protobuf/spark/connect/catalog.proto:
##########
@@ -24,6 +24,41 @@ import "spark/connect/types.proto";
option java_multiple_files = true;
option java_package = "org.apache.spark.connect.proto";
+// Catalog messages are all meant to be internal.
Review Comment:
```suggestion
// Catalog messages are marked as unstable..
```
##########
connector/connect/common/src/main/protobuf/spark/connect/catalog.proto:
##########
@@ -24,6 +24,41 @@ import "spark/connect/types.proto";
option java_multiple_files = true;
option java_package = "org.apache.spark.connect.proto";
+// Catalog messages are all meant to be internal.
Review Comment:
```suggestion
// Catalog messages are marked as unstable.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org