You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "qianye1001 (via GitHub)" <gi...@apache.org> on 2026/09/09 08:55:33 UTC
[PR] [ISSUE #11091] Fix remoting sub-server timeout scanning and scheduler shutdown [rocketmq]
qianye1001 opened a new pull request, #11092:
URL: https://github.com/apache/rocketmq/pull/11092
### Which Issue(s) This PR Fixes
Fixes #11091
### Brief Description
Server-initiated async requests through a `SubRemotingServer` can remain pending indefinitely after a successful write if no response arrives: the shared housekeeping timer scans only the parent response table. Scan every registered remoting server with the existing timer so expired requests trigger timeout callbacks and release their response-table entries and async permits.
Also shut down the remoting-code distribution scheduler when the parent server shuts down, preventing its periodic task and `NettyServerScheduler` thread from surviving server shutdown. No additional threads are introduced.
### How Did You Test This Change?
- Confirmed both regressions on unmodified `develop`: the sub-server timeout callback never completed, and the scheduler remained running after shutdown.
- Added lifecycle tests using the real housekeeping timer and simulated successful channel writes without responses. They cover the parent and two sub servers, timeout callbacks, response-table cleanup, async permit release, preservation of unexpired requests, and scheduler termination.
- JDK 11: `mvn -pl remoting -am -Dtest=NettyRemotingServerLifecycleTest,NettyRemotingServerTest,SubRemotingServerTest,RemotingServerTest,NettyRemotingAbstractTest -Dsurefire.failIfNoSpecifiedTests=false test`, including Checkstyle and SpotBugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #11091] Fix remoting sub-server timeout scanning and scheduler shutdown [rocketmq]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #11092:
URL: https://github.com/apache/rocketmq/pull/11092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #11091] Fix remoting sub-server timeout scanning and scheduler shutdown [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11092:
URL: https://github.com/apache/rocketmq/pull/11092#issuecomment-5600957262
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/11092?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.89%. Comparing base ([`4fd0e3b`](https://app.codecov.io/gh/apache/rocketmq/commit/4fd0e3beeafbb57b8c3050edf5cebcbfde0d2e25?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0cd3d0d`](https://app.codecov.io/gh/apache/rocketmq/commit/0cd3d0d58e39b305bd740de0d255599498b6a52c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #11092 +/- ##
=============================================
- Coverage 48.92% 48.89% -0.03%
+ Complexity 13846 13842 -4
=============================================
Files 1382 1382
Lines 101602 101605 +3
Branches 13213 13214 +1
=============================================
- Hits 49709 49682 -27
- Misses 45866 45885 +19
- Partials 6027 6038 +11
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/rocketmq/pull/11092?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org