[GitHub] [incubator-uniffle] connorlwilkes commented on issue #781: [Bug] Latest Uniffle V0.7 release is broken on kubernetes due to the DefaultStorageManagerProvider

["connorlwilkes (via GitHub)" <gi...@apache.org>]

connorlwilkes commented on issue #781:
URL: https://github.com/apache/incubator-uniffle/issues/781#issuecomment-1488846514

   What have you tested this with? This should function the same way as local provisioner or hostpath volumes.
   
   It is very strange. I noticed that even though there is a failure in this block here:
   ```
   
   for (int i = 0; i < storageBasePaths.size(); i++) {
         final int idx = i;
         String storagePath = storageBasePaths.get(i);
         executorService.submit(() -> {
           try {
             StorageMedia storageType = getStorageTypeForBasePath(storagePath);
             localStorageArray[idx] = LocalStorage.newBuilder()
                 .basePath(storagePath)
                 .capacity(capacity)
                 .lowWaterMarkOfWrite(lowWaterMarkOfWrite)
                 .highWaterMarkOfWrite(highWaterMarkOfWrite)
                 .shuffleExpiredTimeoutMs(shuffleExpiredTimeoutMs)
                 .localStorageMedia(storageType)
                 .build();
             successCount.incrementAndGet();
           } catch (Exception e) {
             LOG.error("LocalStorage init failed!", e);
           } finally {
             countDownLatch.countDown();
           }
         });
       }
   ```
   
   as successCounter is not incremented at all, no exception is logged at all.
   
   I noticed through debugging that that return statement with returning the type of HDD doesn't seem to ever get reached but equally I couldn't see anywhere in the block above it that parses 'sys/block' doesn't throw an exception. In fact from what I could see I am not even sure that 'IS_OS_LINUX' resolves correctly. 
   
   I am a bit stumped as to what the actual issue is here. I have yet to try a try catch over the entire method to see if any exception is hidden somehow but I would expect not 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org