You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@felix.apache.org by cz...@apache.org on 2007/08/15 13:42:56 UTC
svn commit: r566109 -
/felix/trunk/eventadmin/impl/src/main/java/org/apache/felix/eventadmin/impl/tasks/DispatchTask.java
Author: cziegeler
Date: Wed Aug 15 04:42:55 2007
New Revision: 566109
URL: http://svn.apache.org/viewvc?view=rev&rev=566109
Log:
Add missing this :(
Modified:
felix/trunk/eventadmin/impl/src/main/java/org/apache/felix/eventadmin/impl/tasks/DispatchTask.java
Modified: felix/trunk/eventadmin/impl/src/main/java/org/apache/felix/eventadmin/impl/tasks/DispatchTask.java
URL: http://svn.apache.org/viewvc/felix/trunk/eventadmin/impl/src/main/java/org/apache/felix/eventadmin/impl/tasks/DispatchTask.java?view=diff&rev=566109&r1=566108&r2=566109
==============================================================================
--- felix/trunk/eventadmin/impl/src/main/java/org/apache/felix/eventadmin/impl/tasks/DispatchTask.java (original)
+++ felix/trunk/eventadmin/impl/src/main/java/org/apache/felix/eventadmin/impl/tasks/DispatchTask.java Wed Aug 15 04:42:55 2007
@@ -288,7 +288,7 @@
*/
public void cancel()
{
- synchronized (DispatchTask.m_lock)
+ synchronized (DispatchTask.this.m_lock)
{
m_canceled = true;
}
Re: svn commit: r566109 - /felix/trunk/eventadmin/impl/src/main/java/org/apache/felix/eventadmin/impl/tasks/DispatchTask.java
Posted by Carsten Ziegeler <cz...@apache.org>.
Karl Pauls wrote:
> Yes, I can still see lots of changed stuff - so I'll rollback to the
> above revisions for the projects.
>
Sorry for all the trouble - yes, obviously rolling back the commits
would have been
the easier way (I used another tool for removing the "this."...)
Many thanks Karl for resolving this!
Carsten
--
Carsten Ziegeler
cziegeler@apache.org
Re: svn commit: r566109 - /felix/trunk/eventadmin/impl/src/main/java/org/apache/felix/eventadmin/impl/tasks/DispatchTask.java
Posted by Karl Pauls <ka...@gmail.com>.
Yes, I can still see lots of changed stuff - so I'll rollback to the
above revisions for the projects.
regards,
Karl
On 8/15/07, Richard S. Hall <he...@ungoverned.org> wrote:
> Perhaps you should have just revert to the prior revisions, because if
> you miss any places like below it could create some difficult bugs to
> track down...
>
> -> richard
>
> cziegeler@apache.org wrote:
> > Author: cziegeler
> > Date: Wed Aug 15 04:42:55 2007
> > New Revision: 566109
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=566109
> > Log:
> > Add missing this :(
> >
> > Modified:
> > felix/trunk/eventadmin/impl/src/main/java/org/apache/felix/eventadmin/impl/tasks/DispatchTask.java
> >
> > Modified: felix/trunk/eventadmin/impl/src/main/java/org/apache/felix/eventadmin/impl/tasks/DispatchTask.java
> > URL: http://svn.apache.org/viewvc/felix/trunk/eventadmin/impl/src/main/java/org/apache/felix/eventadmin/impl/tasks/DispatchTask.java?view=diff&rev=566109&r1=566108&r2=566109
> > ==============================================================================
> > --- felix/trunk/eventadmin/impl/src/main/java/org/apache/felix/eventadmin/impl/tasks/DispatchTask.java (original)
> > +++ felix/trunk/eventadmin/impl/src/main/java/org/apache/felix/eventadmin/impl/tasks/DispatchTask.java Wed Aug 15 04:42:55 2007
> > @@ -288,7 +288,7 @@
> > */
> > public void cancel()
> > {
> > - synchronized (DispatchTask.m_lock)
> > + synchronized (DispatchTask.this.m_lock)
> > {
> > m_canceled = true;
> > }
> >
> >
>
--
Karl Pauls
karlpauls@gmail.com
Re: svn commit: r566109 - /felix/trunk/eventadmin/impl/src/main/java/org/apache/felix/eventadmin/impl/tasks/DispatchTask.java
Posted by "Richard S. Hall" <he...@ungoverned.org>.
Perhaps you should have just revert to the prior revisions, because if
you miss any places like below it could create some difficult bugs to
track down...
-> richard
cziegeler@apache.org wrote:
> Author: cziegeler
> Date: Wed Aug 15 04:42:55 2007
> New Revision: 566109
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=566109
> Log:
> Add missing this :(
>
> Modified:
> felix/trunk/eventadmin/impl/src/main/java/org/apache/felix/eventadmin/impl/tasks/DispatchTask.java
>
> Modified: felix/trunk/eventadmin/impl/src/main/java/org/apache/felix/eventadmin/impl/tasks/DispatchTask.java
> URL: http://svn.apache.org/viewvc/felix/trunk/eventadmin/impl/src/main/java/org/apache/felix/eventadmin/impl/tasks/DispatchTask.java?view=diff&rev=566109&r1=566108&r2=566109
> ==============================================================================
> --- felix/trunk/eventadmin/impl/src/main/java/org/apache/felix/eventadmin/impl/tasks/DispatchTask.java (original)
> +++ felix/trunk/eventadmin/impl/src/main/java/org/apache/felix/eventadmin/impl/tasks/DispatchTask.java Wed Aug 15 04:42:55 2007
> @@ -288,7 +288,7 @@
> */
> public void cancel()
> {
> - synchronized (DispatchTask.m_lock)
> + synchronized (DispatchTask.this.m_lock)
> {
> m_canceled = true;
> }
>
>