[GitHub] [pulsar] MarvinCai commented on a change in pull request #12128: [pulsar-admin] Allow setting --forward-source-message-property to false when updating a pulsar function

[GitBox <gi...@apache.org>]

MarvinCai commented on a change in pull request #12128:
URL: https://github.com/apache/pulsar/pull/12128#discussion_r714026749



##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -271,7 +271,7 @@ void processArguments() throws Exception {
         protected Boolean retainKeyOrdering;
         @Parameter(names = "--batch-builder", description = "BatcherBuilder provides two types of batch construction methods, DEFAULT and KEY_BASED. The default value is: DEFAULT")
         protected String batchBuilder;
-        @Parameter(names = "--forward-source-message-property", description = "Forwarding input message's properties to output topic when processing")
+        @Parameter(names = "--forward-source-message-property", description = "Forwarding input message's properties to output topic when processing", arity = 1)

Review comment:
       can we update the doc to reflect the change, like `to disable it use --forward-source-message-property false`?
   as user usually won't expect to provide parameter for a `flag` 
   also please rebase on latest master, there's a fix on CI




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org