You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/08/23 22:26:20 UTC
[GitHub] [iceberg] RussellSpitzer opened a new issue #3014: PartitionSpec isUnpartitioned returns true for tables which previously had Partitions but no longer do
RussellSpitzer opened a new issue #3014:
URL: https://github.com/apache/iceberg/issues/3014
Because SpecV1 creates "void" transforms when removing partition transforms, a table whose partitions are removed with a V1 spec will always return an unpartitioned spec.
https://github.com/apache/iceberg/blob/master/api/src/main/java/org/apache/iceberg/PartitionSpec.java#L97-L99
This method should always return true if all of the transforms are void as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on issue #3014: PartitionSpec isUnpartitioned returns true for tables which previously had Partitions but no longer do
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on issue #3014:
URL: https://github.com/apache/iceberg/issues/3014#issuecomment-908685960
@xinbinhuang How are things going?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] xinbinhuang commented on issue #3014: PartitionSpec isUnpartitioned returns true for tables which previously had Partitions but no longer do
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on issue #3014:
URL: https://github.com/apache/iceberg/issues/3014#issuecomment-904180068
@RussellSpitzer can you assign this to me, and timebox it till Thursday? Wanna take a look at iceberg code, but don't want to block it if I get occupied by other things
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer edited a comment on issue #3014: PartitionSpec isUnpartitioned returns true for tables which previously had Partitions but no longer do
Posted by GitBox <gi...@apache.org>.
RussellSpitzer edited a comment on issue #3014:
URL: https://github.com/apache/iceberg/issues/3014#issuecomment-904203379
Done! Let me know if anything is unclear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on issue #3014: PartitionSpec isUnpartitioned returns true for tables which previously had Partitions but no longer do
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on issue #3014:
URL: https://github.com/apache/iceberg/issues/3014#issuecomment-904203379
Done! Let me know if anything is u nclear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] xinbinhuang commented on issue #3014: PartitionSpec isUnpartitioned returns true for tables which previously had Partitions but no longer do
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on issue #3014:
URL: https://github.com/apache/iceberg/issues/3014#issuecomment-909095921
Hi @RussellSpitzer , I had some time to look into the code last week but haven't gotten the time to draft up a PR yet. Planing to do it in the next two days. But I'm aware it has passed quite a few days from last Thursday, so if it'll be too late to get into the release cycle or it blocks other works. Please go ahead to fix it :)
Thanks!
Bin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] xinbinhuang commented on issue #3014: PartitionSpec isUnpartitioned returns true for tables which previously had Partitions but no longer do
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on issue #3014:
URL: https://github.com/apache/iceberg/issues/3014#issuecomment-909095921
Hi @RussellSpitzer , I had some time to look into the code last week but haven't gotten the time to draft up a PR yet. Planing to do it in the next two days. But I'm aware it has passed quite a few days from last Thursday, so if it'll be too late to get into the release cycle or it blocks other works. Please go ahead to fix it :)
Thanks!
Bin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on issue #3014: PartitionSpec isUnpartitioned returns true for tables which previously had Partitions but no longer do
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on issue #3014:
URL: https://github.com/apache/iceberg/issues/3014#issuecomment-908685960
@xinbinhuang How are things going?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] xinbinhuang commented on issue #3014: PartitionSpec isUnpartitioned returns true for tables which previously had Partitions but no longer do
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on issue #3014:
URL: https://github.com/apache/iceberg/issues/3014#issuecomment-909095921
Hi @RussellSpitzer , I had some time to look into the code last week but haven't gotten the time to draft up a PR yet. Planing to do it in the next two days. But I'm aware it has passed quite a few days from last Thursday, so if it'll be too late to get into the release cycle or it blocks other works. Please go ahead to fix it :)
Thanks!
Bin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org