You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tamaya.apache.org by an...@apache.org on 2016/02/19 00:20:31 UTC
incubator-tamaya git commit: TAMAYA-134 Fixed Javadoc issues and some
other quality problems.
Repository: incubator-tamaya
Updated Branches:
refs/heads/master 8fc95128e -> fac47f835
TAMAYA-134 Fixed Javadoc issues and some other quality problems.
Project: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/commit/fac47f83
Tree: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/tree/fac47f83
Diff: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/diff/fac47f83
Branch: refs/heads/master
Commit: fac47f8359b5ccb3ccc5f615efabc2c0bf72c503
Parents: 8fc9512
Author: anatole <an...@apache.org>
Authored: Fri Feb 19 00:20:14 2016 +0100
Committer: anatole <an...@apache.org>
Committed: Fri Feb 19 00:20:14 2016 +0100
----------------------------------------------------------------------
.../apache/tamaya/mutableconfig/MutableConfiguration.java | 4 ++--
.../tamaya/mutableconfig/MutableConfigurationQuery.java | 6 +++---
.../mutableconfig/spi/MutableConfigurationBackendSpi.java | 8 ++------
3 files changed, 7 insertions(+), 11 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/fac47f83/modules/mutable-config/src/main/java/org/apache/tamaya/mutableconfig/MutableConfiguration.java
----------------------------------------------------------------------
diff --git a/modules/mutable-config/src/main/java/org/apache/tamaya/mutableconfig/MutableConfiguration.java b/modules/mutable-config/src/main/java/org/apache/tamaya/mutableconfig/MutableConfiguration.java
index 468c3cd..9b8da41 100644
--- a/modules/mutable-config/src/main/java/org/apache/tamaya/mutableconfig/MutableConfiguration.java
+++ b/modules/mutable-config/src/main/java/org/apache/tamaya/mutableconfig/MutableConfiguration.java
@@ -59,9 +59,9 @@ public interface MutableConfiguration extends Configuration {
* Checks if a configuration key is removable. This also implies that it is writable, but there might be writable
* keys that cannot be removedProperties.
*
- * @param keyExpression the keyExpression the key to be cheched for write access (including creation), not null.
+ * @param keyExpression the keyExpression the key to be checked for write access (including creation), not null.
* Here this could also
- * be a regulat expression, such "as a.b.c.*".
+ * be a regular expression, such "as a.b.c.*".
* @return the boolean
*/
boolean isRemovable(String keyExpression);
http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/fac47f83/modules/mutable-config/src/main/java/org/apache/tamaya/mutableconfig/MutableConfigurationQuery.java
----------------------------------------------------------------------
diff --git a/modules/mutable-config/src/main/java/org/apache/tamaya/mutableconfig/MutableConfigurationQuery.java b/modules/mutable-config/src/main/java/org/apache/tamaya/mutableconfig/MutableConfigurationQuery.java
index 31d6697..2e44a4d 100644
--- a/modules/mutable-config/src/main/java/org/apache/tamaya/mutableconfig/MutableConfigurationQuery.java
+++ b/modules/mutable-config/src/main/java/org/apache/tamaya/mutableconfig/MutableConfigurationQuery.java
@@ -47,7 +47,7 @@ public final class MutableConfigurationQuery implements ConfigQuery<MutableConfi
/**
* URIs used by this query instance to identify the backends to use for write operations.
*/
- private List<MutableConfigurationBackendSpi> targets = new ArrayList<>();
+ private final List<MutableConfigurationBackendSpi> targets = new ArrayList<>();
/** Singleton constructor. */
private MutableConfigurationQuery(List<MutableConfigurationBackendSpi> targets){
@@ -77,7 +77,7 @@ public final class MutableConfigurationQuery implements ConfigQuery<MutableConfi
}
return of(uris);
} catch(URISyntaxException e){
- throw new ConfigException("Invalid URIs enocuntered in " + Arrays.toString(configurationTargets));
+ throw new ConfigException("Invalid URIs encountered in " + Arrays.toString(configurationTargets));
}
}
@@ -129,7 +129,7 @@ public final class MutableConfigurationQuery implements ConfigQuery<MutableConfi
@Override
public List<URI> getBackendURIs() {
- List<URI> result = new ArrayList<>(getBackendURIs().size());
+ List<URI> result = new ArrayList<>(targets.size());
for(MutableConfigurationBackendSpi backend: targets){
result.add(backend.getBackendURI());
}
http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/fac47f83/modules/mutable-config/src/main/java/org/apache/tamaya/mutableconfig/spi/MutableConfigurationBackendSpi.java
----------------------------------------------------------------------
diff --git a/modules/mutable-config/src/main/java/org/apache/tamaya/mutableconfig/spi/MutableConfigurationBackendSpi.java b/modules/mutable-config/src/main/java/org/apache/tamaya/mutableconfig/spi/MutableConfigurationBackendSpi.java
index 0c05807..1541f26 100644
--- a/modules/mutable-config/src/main/java/org/apache/tamaya/mutableconfig/spi/MutableConfigurationBackendSpi.java
+++ b/modules/mutable-config/src/main/java/org/apache/tamaya/mutableconfig/spi/MutableConfigurationBackendSpi.java
@@ -52,9 +52,9 @@ public interface MutableConfigurationBackendSpi {
* Checks if a configuration key is removable. This also implies that it is writable, but there might be writable
* keys that cannot be removedProperties.
*
- * @param keyExpression the keyExpression the key to be cheched for write access (including creation), not null.
+ * @param keyExpression the keyExpression the key to be checked for write access (including creation), not null.
* Here this could also
- * be a regulat expression, such "as a.b.c.*".
+ * be a regular expression, such "as a.b.c.*".
* @return the boolean
*/
boolean isRemovable(String keyExpression);
@@ -75,7 +75,6 @@ public interface MutableConfigurationBackendSpi {
*
* @param key the property's key, not null.
* @param value the property's value, not null.
- * @return the former property value, or null.
* @throws org.apache.tamaya.ConfigException if the key/value cannot be added, or the request is read-only.
*/
void put(String key, String value);
@@ -89,7 +88,6 @@ public interface MutableConfigurationBackendSpi {
* remove all entries as far as possible and abort the writing operation.
*
* @param properties the properties tobe written, not null.
- * @return the config change request
* @throws org.apache.tamaya.ConfigException if any of the given properties could not be written, or the request is read-only.
*/
void putAll(Map<String, String> properties);
@@ -103,7 +101,6 @@ public interface MutableConfigurationBackendSpi {
* remove all entries as far as possible and abort the writing operation.
*
* @param keys the property's keys to be removedProperties, not null.
- * @return the config change request
* @throws org.apache.tamaya.ConfigException if any of the given keys could not be removedProperties, or the request is read-only.
*/
void remove(Collection<String> keys);
@@ -117,7 +114,6 @@ public interface MutableConfigurationBackendSpi {
* remove all entries as far as possible and abort the writing operation.
*
* @param keys the property's keys to be removedProperties, not null.
- * @return the config change request
* @throws org.apache.tamaya.ConfigException if any of the given keys could not be removedProperties, or the request is read-only.
*/
void remove(String... keys);