Re: [PR] HDDS-16643. Remove CleanupTableInfo mechanism [ozone]

["szetszwo (via GitHub)" <gi...@apache.org>]

szetszwo commented on code in PR #11365:
URL: https://github.com/apache/ozone/pull/11365#discussion_r4167633590


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/S3SecretManager.java:
##########
@@ -102,6 +105,7 @@ default void updateCache(String accessId, S3SecretValue secret) {
     if (cache != null) {
       LOG.info("Updating cache for accessId/user: {}.", accessId);
       cache.put(accessId, secret);
+      TableCacheUpdateTracker.recordCacheUpdate(S3_SECRET_TABLE);

Review Comment:
   Question: why track it here?



##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/file/OMDirectoryCreateResponseWithFSO.java:
##########
@@ -71,7 +65,6 @@ public OMDirectoryCreateResponseWithFSO(@Nonnull OMResponse omResponse,
   public OMDirectoryCreateResponseWithFSO(@Nonnull OMResponse omResponse,
                                      @Nonnull Result result) {

Review Comment:
   Let's remove the result parameter.  (If no further change is needed, let's just merge this PR and fix this later.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org