You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fury.apache.org by "chaokunyang (via GitHub)" <gi...@apache.org> on 2024/04/27 05:53:53 UTC
[I] Remove commented content in git commit message [incubator-fury]
chaokunyang opened a new issue, #1588:
URL: https://github.com/apache/incubator-fury/issues/1588
## Is your feature request related to a problem? Please describe.
Currently there are many comments contents in PR.
```
<!--
**Thanks for contributing to Fury.**
**If this is your first time opening a PR on fury, you can refer to [CONTRIBUTING.md](https://github.com/apache/incubator-fury/blob/main/CONTRIBUTING.md).**
Contribution Checklist
- The **Apache Fury (incubating)** community has restrictions on the naming of pr titles. You can also find instructions in [CONTRIBUTING.md](https://github.com/apache/incubator-fury/blob/main/CONTRIBUTING.md).
- Fury has a strong focus on performance. If the PR you submit will have an impact on performance, please benchmark it first and provide the benchmark result here.
-->
## What does this PR do?
<!-- Describe the purpose of this PR. -->
## Related issues
<!--
Is there any related issue? Please attach here.
- #xxxx0
- #xxxx1
- #xxxx2
-->
## Does this PR introduce any user-facing change?
<!--
If any user-facing interface changes, please [open an issue](https://github.com/apache/incubator-fury/issues/new/choose) describing the need to do so and update the document if necessary.
-->
- [ ] Does this PR introduce any public API change?
- [ ] Does this PR introduce any binary protocol compatibility change?
## Benchmark
<!--
When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here.
-->
```
If contributor doesn't remove it, it will be included in the commited message, which make the git history kinds of messy.
## Describe the solution you'd like
We should remove such conents automatically before merge PR
## Additional context
<!-- Add any other context or screenshots about the feature request here. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] Remove commented content in git commit message [fory]
Posted by "urlyy (via GitHub)" <gi...@apache.org>.
urlyy commented on issue #1588:
URL: https://github.com/apache/fory/issues/1588#issuecomment-3058086007
> The action exists now because you created it: https://github.com/marketplace/actions/remove-markdown-comments-in-pr
>
> Are you going to integrate it?
I won't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [I] Remove commented content in git commit message [fury]
Posted by "urlyy (via GitHub)" <gi...@apache.org>.
urlyy commented on issue #1588:
URL: https://github.com/apache/fury/issues/1588#issuecomment-2217528810
I have tested it in my own copied repository, and it is effective, you can see in https://github.com/urlyy/fury_action_test/pull/1. But I don't know if you are satisfied with this effect, and whether submitting a PR about modifying the project's CI/CD is dangerous. Looking forward to your reply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] Remove commented content in git commit message [fury]
Posted by "urlyy (via GitHub)" <gi...@apache.org>.
urlyy commented on issue #1588:
URL: https://github.com/apache/fury/issues/1588#issuecomment-2211765202
I have created a github action: [Remove markdown comments in PR](https://github.com/marketplace/actions/remove-markdown-comments-in-pr), detail usage are provided in its README. But if `<!-- comment -->` in PR body `code blocks` , it will also be removed.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] Remove commented content in git commit message [fory]
Posted by "urlyy (via GitHub)" <gi...@apache.org>.
urlyy commented on issue #1588:
URL: https://github.com/apache/fory/issues/1588#issuecomment-3059562895
> Have you used it anywhere; is it tested?
Both no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [I] Remove commented content in git commit message [fory]
Posted by "esafak (via GitHub)" <gi...@apache.org>.
esafak commented on issue #1588:
URL: https://github.com/apache/fory/issues/1588#issuecomment-3058050284
The action exists now because you created it: https://github.com/marketplace/actions/remove-markdown-comments-in-pr
Are you going to integrate it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [I] Remove commented content in git commit message [fory]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang closed issue #1588: Remove commented content in git commit message
URL: https://github.com/apache/fory/issues/1588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [I] Remove commented content in git commit message [fury]
Posted by "urlyy (via GitHub)" <gi...@apache.org>.
urlyy commented on issue #1588:
URL: https://github.com/apache/fury/issues/1588#issuecomment-2208087225
That's strange. Do you copy the PR body into the merge description when confirming a merge? If so, I think we can modify the PR body automatically after people create the PR. I found a GitHub Actions plugin: [Update PR Description](https://github.com/marketplace/actions/update-pr-description) that works as follows.

and it works on my demo

However, for this issue, it might be necessary to create a custom action plugin. I'd like to take this on, but I'm not very familiar with writing action plugins. Could you allow me a few days to study this and then we can continue the discussion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] Remove commented content in git commit message [fory]
Posted by "esafak (via GitHub)" <gi...@apache.org>.
esafak commented on issue #1588:
URL: https://github.com/apache/fory/issues/1588#issuecomment-3058145615
Have you used it anywhere; is it tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [I] Remove commented content in git commit message [fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on issue #1588:
URL: https://github.com/apache/fury/issues/1588#issuecomment-2208489460
Of course, feel free to study this at your own pace. This is not urgent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] Remove commented content in git commit message [fury]
Posted by "urlyy (via GitHub)" <gi...@apache.org>.
urlyy commented on issue #1588:
URL: https://github.com/apache/fury/issues/1588#issuecomment-2217854919
> I will take a look later. It needs a token, we need to ensure it's safe. I'm not familiar with github action. BTW, this is a common issue, is there any github action which has implemented this feature?
Sorry, I didn't spend much time searching to see if relavant github action exists. I'll go check it out now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] Remove commented content in git commit message [fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on issue #1588:
URL: https://github.com/apache/fury/issues/1588#issuecomment-2217848939
I will take a look later. It needs a token, we need to ensure it's safe. I'm not familiar with github action.
BTW, this is a common issue, is there any github action which has implemented this feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org