[GitHub] [airflow] o-nikolas commented on a diff in pull request #26606: Remove S3KeysUnchangedSensor from S3 system test

[GitBox <gi...@apache.org>]

o-nikolas commented on code in PR #26606:
URL: https://github.com/apache/airflow/pull/26606#discussion_r981592300


##########
tests/system/providers/amazon/aws/example_s3.py:
##########
@@ -202,6 +203,12 @@ def check_fn(files: list) -> bool:
     )
     # [END howto_operator_s3_file_transform]
 
+    # This task skips the `sensor_keys_unchanged` task because the S3KeysUnchangedSensor

Review Comment:
   > Other option is to design the tests in a way, that if sensor is in reschedule mode it will not fail on first try (ie. if you're waiting for some file to appear, to upload the file first then run the sensor).
   
   Interesting! This would be quite a fundamental change since it's fairly deep in core Airflow code where the sensor mode is hard coded to reschedule, so to hook into that would be tricky.
   
   Can we at least agree to create a new issue to track this possible work so that we can unblock this PR? We're happy to skip this one sensor as this PR suggest, to unblock getting coverage from the rest of this test module.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org