You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/06/21 17:57:14 UTC
[GitHub] [camel-quarkus] lburgazzoli opened a new issue #1399: Observe Camel's Lifecycle events
lburgazzoli opened a new issue #1399:
URL: https://github.com/apache/camel-quarkus/issues/1399
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli closed issue #1399: Observe Camel's Lifecycle events
Posted by GitBox <gi...@apache.org>.
lburgazzoli closed issue #1399:
URL: https://github.com/apache/camel-quarkus/issues/1399
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli edited a comment on issue #1399: Observe Camel's Lifecycle events
Posted by GitBox <gi...@apache.org>.
lburgazzoli edited a comment on issue #1399:
URL: https://github.com/apache/camel-quarkus/issues/1399#issuecomment-647437597
I was thinking about have just a single set of events, as example you can listen for Context start event with both a life-cycle callback and with a management event so there's some duplication and I didn't want to expose both to avoid confusion.
It relates to: https://issues.apache.org/jira/browse/CAMEL-11566
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on issue #1399: Observe Camel's Lifecycle events
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #1399:
URL: https://github.com/apache/camel-quarkus/issues/1399#issuecomment-647461894
@davsclaus added the missing non overlapping events
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] davsclaus commented on issue #1399: Observe Camel's Lifecycle events
Posted by GitBox <gi...@apache.org>.
davsclaus commented on issue #1399:
URL: https://github.com/apache/camel-quarkus/issues/1399#issuecomment-647466338
Ah okay, so you wanted to present this to the camel-quarkus end users as a uniform api using standard java events. So you dont need to choose when to use lifecycle vs events.
Yeah ideally events should be for end users, and lifecycle for component developers where you need some special integration (spi interface).
But historically then there was only lifecycle in the start of Camel and events was added later, that was a bit tied to jmx events in the start.
However would likely be good to make end users go for events in camel-core over lifecycle.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on issue #1399: Observe Camel's Lifecycle events
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #1399:
URL: https://github.com/apache/camel-quarkus/issues/1399#issuecomment-647437597
I was thinking about have just a single set of events, as example you can listen for Context start event with both a life-cycle callback and with a management event so there's some duplication and I didn't want to expose both to avoid confusion.
Relates to: https://issues.apache.org/jira/browse/CAMEL-11566?filter=12334535
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli edited a comment on issue #1399: Observe Camel's Lifecycle events
Posted by GitBox <gi...@apache.org>.
lburgazzoli edited a comment on issue #1399:
URL: https://github.com/apache/camel-quarkus/issues/1399#issuecomment-647181072
There's some overlap between life-cycle and management events:
- [LifecycleStrategy](https://github.com/apache/camel/blob/master/core/camel-api/src/main/java/org/apache/camel/spi/LifecycleStrategy.java)
- [CamelEvent](https://github.com/apache/camel/blob/master/core/camel-api/src/main/java/org/apache/camel/spi/CamelEvent.java)
@jamesnetherton @davsclaus wonder if we should limit life-cycle events to _onComponent_ (add/remove) and _onEndpoint_ (add/remove) and wrap them as custom `CamelEvent`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on issue #1399: Observe Camel's Lifecycle events
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #1399:
URL: https://github.com/apache/camel-quarkus/issues/1399#issuecomment-647394482
@jamesnetherton @davsclaus a possible implementation proposed as #1404
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on issue #1399: Observe Camel's Lifecycle events
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #1399:
URL: https://github.com/apache/camel-quarkus/issues/1399#issuecomment-647181072
There's some overlap between life-cycle and management events:
- [LifecycleStrategy](https://github.com/apache/camel/blob/master/core/camel-api/src/main/java/org/apache/camel/spi/LifecycleStrategy.java)
- [CamelEvent](https://github.com/apache/camel/blob/master/core/camel-api/src/main/java/org/apache/camel/spi/CamelEvent.java)
@jamesnetherton wonder if we should limit life-cycle events to _onComponent_ (add/remove) and _onEndpoint_ (add/remove) and wrap them as custom `CamelEvent`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] davsclaus commented on issue #1399: Observe Camel's Lifecycle events
Posted by GitBox <gi...@apache.org>.
davsclaus commented on issue #1399:
URL: https://github.com/apache/camel-quarkus/issues/1399#issuecomment-647433441
Okay so if we only listen for component add/remove endpoint add/remove is there a special reason for this? Just wonder
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org