You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/11/25 08:34:40 UTC
[GitHub] [dubbo] AlbumenJ opened a new issue, #11027: Fix ConcurrentModificationException in application DeployListener
AlbumenJ opened a new issue, #11027:
URL: https://github.com/apache/dubbo/issues/11027
<!-- If you need to report a security issue please visit https://github.com/apache/dubbo/security/policy -->
- [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate.
Related with https://github.com/apache/dubbo/issues/11002
### Steps to reproduce this issue
Use API and to init a service/reference config parallel.
Pls. provide [GitHub address] to reproduce this issue.
### Expected Behavior
<!-- What do you expect from the above steps？-->
### Actual Behavior
<!-- What actually happens? -->
If there is an exception, please attach the exception trace:
```
Just put your stack trace here!
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] IncrementalRefinement commented on issue #11027: Fix ConcurrentModificationException in application DeployListener
Posted by GitBox <gi...@apache.org>.
IncrementalRefinement commented on issue #11027:
URL: https://github.com/apache/dubbo/issues/11027#issuecomment-1328726693
I think the main issue of https://github.com/apache/dubbo/issues/11002 is that the concurrent access of the Deployer is happed both within the Spring framework and the user code. In other words, the IOC container hasn't prepared the bean yet but the user code tries to access the bean already. This way of access the bean violates the principal is against the principal of IOC. So I don't think we should consider to fix this issue in Dubbo.
If we really want to fix this problem, maybe we can make the DefaultModuleDeployer implements ApplicationListener interface and add the Anonymous DeployListenerAdapter to the AbstractDeployer#listeners in its constructor?(I personally don't recommend that)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] Fix ConcurrentModificationException in application DeployListener [dubbo]
Posted by "CrazyHZM (via GitHub)" <gi...@apache.org>.
CrazyHZM closed issue #11027: Fix ConcurrentModificationException in application DeployListener
URL: https://github.com/apache/dubbo/issues/11027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on issue #11027: Fix ConcurrentModificationException in application DeployListener
Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on issue #11027:
URL: https://github.com/apache/dubbo/issues/11027#issuecomment-1330044463
> I think the main issue of https://github.com/apache/dubbo/issues/11002 is that the concurrent access of the Deployer is happed both within the Spring framework and the user code. In other words, the IOC container hasn't prepared the bean yet but the user code tries to access the bean already. This way of access the bean violates the principal of IcC. So I don't think we should consider to fix this issue in Dubbo.
The API usage of Dubbo is not a bean of Spring. The API usage and Spring usage are the two basic usage of Dubbo.
So, the core issue is API usage and Spring usage are conflict when init.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] IncrementalRefinement commented on issue #11027: Fix ConcurrentModificationException in application DeployListener
Posted by GitBox <gi...@apache.org>.
IncrementalRefinement commented on issue #11027:
URL: https://github.com/apache/dubbo/issues/11027#issuecomment-1330089772
> > I think the main issue of #11002 is that the concurrent access of the Deployer is happed both within the Spring framework and the user code. In other words, the IOC container hasn't prepared the bean yet but the user code tries to access the bean already. This way of access the bean violates the principal of IcC. So I don't think we should consider to fix this issue in Dubbo.
>
> The API usage of Dubbo is not a bean of Spring. The API usage and Spring usage are the two basic usage of Dubbo.
>
> So, the core issue is API usage and Spring usage are conflict when init.
But the API usage is concurrently accessed the AbstractDeployer(which is eventually complete after DubboDeployApplicationListener add DeployListener) together with the Spring usage. Would't this be a dangerous and not-recommended operation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on issue #11027: Fix ConcurrentModificationException in application DeployListener
Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on issue #11027:
URL: https://github.com/apache/dubbo/issues/11027#issuecomment-1330130027
> > > I think the main issue of #11002 is that the concurrent access of the Deployer is happed both within the Spring framework and the user code. In other words, the IOC container hasn't prepared the bean yet but the user code tries to access the bean already. This way of access the bean violates the principal of IcC. So I don't think we should consider to fix this issue in Dubbo.
> >
> >
> > The API usage of Dubbo is not a bean of Spring. The API usage and Spring usage are the two basic usage of Dubbo.
> > So, the core issue is API usage and Spring usage are conflict when init.
>
> But the API usage is concurrently accessed the AbstractDeployer(which is eventually complete after DubboDeployApplicationListener add DeployListener) together with the Spring usage. Would't this be a dangerous and not-recommended operation?
We should find out a proper opportunity to make them synchronized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org