You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@storm.apache.org by sr...@apache.org on 2015/02/23 23:21:59 UTC

[04/21] storm git commit: STORM-616:Adding storm-jdbc as external module in pom. Adding links to hikariCP configuration in README.

STORM-616:Adding storm-jdbc as external module in pom. Adding links to hikariCP configuration in README.


Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/079deda4
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/079deda4
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/079deda4

Branch: refs/heads/master
Commit: 079deda496d16bd896611da706402c9df7e2319f
Parents: d260759
Author: Parth Brahmbhatt <br...@gmail.com>
Authored: Tue Jan 6 12:47:40 2015 -0500
Committer: Parth Brahmbhatt <br...@gmail.com>
Committed: Tue Jan 6 12:47:40 2015 -0500

----------------------------------------------------------------------
 external/storm-jdbc/README.md | 3 ++-
 external/storm-jdbc/pom.xml   | 5 +++++
 pom.xml                       | 1 +
 3 files changed, 8 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/storm/blob/079deda4/external/storm-jdbc/README.md
----------------------------------------------------------------------
diff --git a/external/storm-jdbc/README.md b/external/storm-jdbc/README.md
index 36db3ef..a0273f2 100644
--- a/external/storm-jdbc/README.md
+++ b/external/storm-jdbc/README.md
@@ -25,7 +25,8 @@ The following code creates a `SimpleJdbcMapper` instance that:
 
 1. Will allow the mapper to transform a storm tuple to a list of columns mapping to a row in table test.user_details.
 2. Will use the provided HikariCP configuration to establish a connection pool with specified Database configuration and
-automatically figure out the column names of the table that you intend to write to.
+automatically figure out the column names of the table that you intend to write to. 
+Please see https://github.com/brettwooldridge/HikariCP#configuration-knobs-baby to lear more about hikari configuration properties.
 
 ```java
 Map hikariConfigMap = Maps.newHashMap();

http://git-wip-us.apache.org/repos/asf/storm/blob/079deda4/external/storm-jdbc/pom.xml
----------------------------------------------------------------------
diff --git a/external/storm-jdbc/pom.xml b/external/storm-jdbc/pom.xml
index 9130908..894dd54 100644
--- a/external/storm-jdbc/pom.xml
+++ b/external/storm-jdbc/pom.xml
@@ -52,6 +52,11 @@
             <version>3.3</version>
         </dependency>
         <dependency>
+            <groupId>com.google.guava</groupId>
+            <artifactId>guava</artifactId>
+            <version>17.0</version>
+        </dependency>
+        <dependency>
             <groupId>com.zaxxer</groupId>
             <artifactId>HikariCP-java6</artifactId>
             <version>${hikari.version}</version>

http://git-wip-us.apache.org/repos/asf/storm/blob/079deda4/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 5645b9a..8604dab 100644
--- a/pom.xml
+++ b/pom.xml
@@ -161,6 +161,7 @@
         <module>external/storm-kafka</module>
         <module>external/storm-hdfs</module>
         <module>external/storm-hbase</module>
+        <module>external/storm-jdbc</module>
     </modules>
 
     <scm>