Re: [lucy-dev] [VOTE] Apache Lucy (incubating) 0.2.2 RC 1 (cleanup)

[Moritz Lenz <mo...@faui2k3.org>]

FWIW all tests pass on Debian GNU/Linux stable with a custom perl
5.14.1, same with the system perl (5.10.1).

However I had to wipe out the directory between the two tests, because
the build and configuration left some files behind which ./Build clean
in the perl/ subdirectory did not clean, and which caused some @INC
paths to be set up wrongly.

Here  is the list of files that remain after a

$ cd perl/
$ perl Build.PL
$ ./Build test
$ ./Build clean

list of files:

#       clownfish/Build
#       clownfish/MYMETA.json
#       clownfish/MYMETA.yml
#       clownfish/_build/
#       perl/Build
#       perl/MYMETA.json
#       perl/MYMETA.yml
#       perl/_build/

In particular the clownfish/Build script contains a path to the perl
binary that was used to run Build.PL in the perl/ directory, but when
running the perl/Build.PL with a different perl binary again, the
clownfish/Build file is not regenerated.

So this is a relative obscure case, and I don't think it should hold off
the release, but it would be nice if './Build clean' was a bit more
thorough -- at least the {perl,clownfish/_build/ directories should be
cleaned, IMHO. The MYMETA files are harmless.

Cheers,
Moritz

Re: [lucy-dev] [VOTE] Apache Lucy (incubating) 0.2.2 RC 1 (cleanup)

[Marvin Humphrey <ma...@rectangular.com>]

Hi Moritz, thanks for reviewing the release candidate and reporting your
findings!

On Sat, Oct 22, 2011 at 08:26:15PM +0200, Moritz Lenz wrote:
> FWIW all tests pass on Debian GNU/Linux stable with a custom perl
> 5.14.1, same with the system perl (5.10.1).

:)

> However I had to wipe out the directory between the two tests, because
> the build and configuration left some files behind which ./Build clean
> in the perl/ subdirectory did not clean, and which caused some @INC
> paths to be set up wrongly.

I believe that this patch to the 0.2 branch would produce your desired
behavior:

--- perl/buildlib/Lucy/Build.pm (revision 1187752)
+++ perl/buildlib/Lucy/Build.pm (working copy)
@@ -716,8 +716,8 @@
 sub ACTION_clean {
     my $self = shift;
     if ( -e $CLOWNFISH_BUILD ) {
-        system("$^X $CLOWNFISH_BUILD clean")
-            and die "Clownfish clean failed";
+        system("$^X $CLOWNFISH_BUILD realclean")
+            and die "Clownfish realclean failed";
     }
     $self->_run_make( dir => $CHARMONIZER_ORIG_DIR, args => ['clean'] );
     $self->SUPER::ACTION_clean;

I'm not sure that's technically "correct", because I think you are supposed to
supposed to invoke './Build realclean' rather than './Build clean' when
switching Perl executables.  However, it seems that './Build clean' works
under ordinary circumstances whether or not it ought to, and so +1 to make it
work for Lucy.

Can you please open a ticket?

    http://issues.apache.org/jira/browse/LUCY

Marvin Humphrey