You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/16 12:52:15 UTC
[GitHub] [shardingsphere] sluk3r opened a new pull request #7491: test cases added for ProxyContext
sluk3r opened a new pull request #7491:
URL: https://github.com/apache/shardingsphere/pull/7491
Fixes #7331.
following test cases added:
assertInit
assertSchemaExists
assertGetSchema
assertGetAllSchemaNames
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #7491: test cases added for ProxyContext
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #7491:
URL: https://github.com/apache/shardingsphere/pull/7491#discussion_r489412279
##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/test/java/org/apache/shardingsphere/proxy/backend/context/ProxyContextTest.java
##########
@@ -65,4 +143,5 @@ public void assertGetDataSourceSample() throws NoSuchFieldException, IllegalAcce
when(schemaContext.getRuntimeContext()).thenReturn(runtimeContext);
return Collections.singletonMap("schema", schemaContext);
}
+
Review comment:
Please remove useless blank line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #7491: test cases added for ProxyContext
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #7491:
URL: https://github.com/apache/shardingsphere/pull/7491
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sluk3r commented on a change in pull request #7491: test cases added for ProxyContext
Posted by GitBox <gi...@apache.org>.
sluk3r commented on a change in pull request #7491:
URL: https://github.com/apache/shardingsphere/pull/7491#discussion_r489456053
##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/test/java/org/apache/shardingsphere/proxy/backend/context/ProxyContextTest.java
##########
@@ -65,4 +143,5 @@ public void assertGetDataSourceSample() throws NoSuchFieldException, IllegalAcce
when(schemaContext.getRuntimeContext()).thenReturn(runtimeContext);
return Collections.singletonMap("schema", schemaContext);
}
+
Review comment:
removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org