You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/21 21:06:07 UTC
[GitHub] [helix] kaisun2000 opened a new issue #1299: Fix flaky test TestDisableCustomCodeRunner.test
kaisun2000 opened a new issue #1299:
URL: https://github.com/apache/helix/issues/1299
LOG: (368)
>2020-08-21T06:26:35.4952198Z [ERROR] test(org.apache.helix.integration.TestDisableCustomCodeRunner) Time elapsed: 1.565 s <<< FAILURE!
2020-08-21T06:26:35.4957513Z java.lang.AssertionError: expected:<false> but was:<true>
2020-08-21T06:26:35.4967225Z at org.apache.helix.integration.TestDisableCustomCodeRunner.test(TestDisableCustomCodeRunner.java:233)
2020-08-21T06:26:35.4968993Z
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on issue #1299: Fix flaky test TestDisableCustomCodeRunner.test
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on issue #1299:
URL: https://github.com/apache/helix/issues/1299#issuecomment-692905522
```
// Re-enable custom-code runner
admin.enableResource(clusterName, customCodeRunnerResource, true);
ClusterStateVerifier.BestPossAndExtViewZkVerifier
verifier = new ClusterStateVerifier.BestPossAndExtViewZkVerifier(ZK_ADDR, clusterName);
try {
result = ClusterStateVerifier.verifyByPolling(verifier, TestHelper.WAIT_DURATION);
Assert.assertTrue(result);
} finally {
verifier.close();
}
```
This seems a typical case without waiting before verifyByPolling, the verification can be too early.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on issue #1299: Fix flaky test TestDisableCustomCodeRunner.test
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on issue #1299:
URL: https://github.com/apache/helix/issues/1299#issuecomment-678499715
Need investigate more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang closed issue #1299: Fix flaky test TestDisableCustomCodeRunner.test
Posted by GitBox <gi...@apache.org>.
jiajunwang closed issue #1299:
URL: https://github.com/apache/helix/issues/1299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on issue #1299: Fix flaky test TestDisableCustomCodeRunner.test
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on issue #1299:
URL: https://github.com/apache/helix/issues/1299#issuecomment-693818817
second issue:
>2020-09-17T03:50:18.5157922Z [ERROR] test(org.apache.helix.integration.TestDisableCustomCodeRunner) Time elapsed: 3.475 s <<< FAILURE!
2020-09-17T03:50:18.5159810Z java.lang.AssertionError: expected:<false> but was:<true>
2020-09-17T03:50:18.5161652Z at org.apache.helix.integration.TestDisableCustomCodeRunner.test(TestDisableCustomCodeRunner.java:236)
2020-09-17T03:50:18.5163211Z
2020
code:
```
for (String instance : callbacks.keySet()) {
DummyCallback callback = callbacks.get(instance);
if (instance.equals(leader)) {
Assert.assertTrue(callback.isInitTypeInvoked());
} else {
Assert.assertFalse(callback.isInitTypeInvoked()); -->
}
callback.reset();
```
The question boils down why the assertion should be right? Let us disable it for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org