You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by st...@apache.org on 2026/03/09 11:05:16 UTC

(hadoop) 01/02: HADOOP-19826. Add contract test to verify renaming empty dir works. (#8304)

This is an automated email from the ASF dual-hosted git repository.

stevel pushed a commit to branch branch-3.5
in repository https://gitbox.apache.org/repos/asf/hadoop.git

commit 2b87adab2497291a5accf6a4d83c2ebc3b56450d
Author: Deepak Jain <de...@users.noreply.github.com>
AuthorDate: Mon Mar 9 03:56:28 2026 -0700

    HADOOP-19826. Add contract test to verify renaming empty dir works. (#8304)
    
    Add testRenameEmptyDir in AbstractContractRenameTest.
    
    Contributed by Deepak Jain
---
 .../hadoop/fs/contract/AbstractContractRenameTest.java   | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractRenameTest.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractRenameTest.java
index 19a1ac96d08..b5b2903aaf7 100644
--- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractRenameTest.java
+++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractRenameTest.java
@@ -146,6 +146,22 @@ public void testRenameFileOverExistingFile() throws Throwable {
         destUnchanged ? destData: srcData);
   }
 
+  @Test
+  public void testRenameEmptyDir() throws Throwable {
+    describe("Verify renaming an empty directory to a new path works");
+    FileSystem fs = getFileSystem();
+    Path emptySrc = path("testRenameEmptyDir/src");
+    Path emptyDest = path("testRenameEmptyDir/dest");
+    mkdirs(emptySrc.getParent());
+    fs.mkdirs(emptySrc);
+    assertIsDirectory(emptySrc);
+    boolean renamed = rename(emptySrc, emptyDest);
+    assertTrue(renamed, "rename(emptyDir, newPath) should return true");
+    assertIsDirectory(emptyDest);
+    assertPathDoesNotExist("source empty dir should not exist after rename",
+        emptySrc);
+  }
+
   @Test
   public void testRenameDirIntoExistingDir() throws Throwable {
     describe("Verify renaming a dir into an existing dir puts it"


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org