You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "bereng (via GitHub)" <gi...@apache.org> on 2023/07/12 09:39:36 UTC
[GitHub] [cassandra] bereng opened a new pull request, #2482: Cassandra 18338 4.1
bereng opened a new pull request, #2482:
URL: https://github.com/apache/cassandra/pull/2482
Thanks for sending a pull request! Here are some tips if you're new here:
* Ensure you have added or run the [appropriate tests](https://cassandra.apache.org/_/development/testing.html) for your PR.
* Be sure to keep the PR description updated to reflect all changes.
* Write your PR title to summarize what this PR proposes.
* If possible, provide a concise example to reproduce the issue for a faster review.
* Read our [contributor guidelines](https://cassandra.apache.org/_/development/index.html)
* If you're making a documentation change, see our [guide to documentation contribution](https://cassandra.apache.org/_/development/documentation.html)
Commit messages should follow the following format:
```
<One sentence description, usually Jira title or CHANGES.txt summary>
<Optional lengthier description (context on patch)>
patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####
Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>
```
The [Cassandra Jira](https://issues.apache.org/jira/projects/CASSANDRA/issues/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng closed pull request #2482: Cassandra 18338 4.1
Posted by "bereng (via GitHub)" <gi...@apache.org>.
bereng closed pull request #2482: Cassandra 18338 4.1
URL: https://github.com/apache/cassandra/pull/2482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on pull request #2482: Cassandra 18338 4.1
Posted by "bereng (via GitHub)" <gi...@apache.org>.
bereng commented on PR #2482:
URL: https://github.com/apache/cassandra/pull/2482#issuecomment-1635333873
Squashed for commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] bereng commented on pull request #2482: Cassandra 18338 4.1
Posted by "bereng (via GitHub)" <gi...@apache.org>.
bereng commented on PR #2482:
URL: https://github.com/apache/cassandra/pull/2482#issuecomment-1632185292
We shouldn't count SELECTS we didn't issue. That seems to pass.
Ci 10K repeats is [green](https://app.circleci.com/pipelines/github/bereng/cassandra/1009/workflows/dd503816-a028-4aba-9ae4-7400862efe58/jobs/22549)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] adelapena commented on a diff in pull request #2482: Cassandra 18338 4.1
Posted by "adelapena (via GitHub)" <gi...@apache.org>.
adelapena commented on code in PR #2482:
URL: https://github.com/apache/cassandra/pull/2482#discussion_r1261231718
##########
test/distributed/org/apache/cassandra/distributed/test/ByteBuddyExamplesTest.java:
##########
@@ -115,8 +117,12 @@ static void install(ClassLoader cl, int nodeNumber)
public static ResultMessage.Rows execute(QueryState state, QueryOptions options, long queryStartNanoTime, @SuperCall Callable<ResultMessage.Rows> r) throws Exception
{
- count.incrementAndGet();
- return r.call();
+ Rows res = r.call();
+
+ if (res.result.metadata.names.stream().map(c -> c.toString()).collect(Collectors.toList()).contains("bytebuddy_test_column"))
Review Comment:
Super nit: can use a method reference
```suggestion
if (res.result.metadata.names.stream().map(ColumnSpecification::toString).collect(Collectors.toList()).contains("bytebuddy_test_column"))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org