You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cayenne.apache.org by "Andrus Adamchik (Closed) (JIRA)" <ji...@apache.org> on 2012/02/09 10:28:59 UTC

[jira] [Closed] (CAY-1655) Logger injection to JdbcAdapter subclass does not work

     [ https://issues.apache.org/jira/browse/CAY-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrus Adamchik closed CAY-1655.
--------------------------------

    Resolution: Not A Problem

That explains it. "return new MyCustomAdapter(); " is how adapter is created. There's nothing in this code that can perform injection. Looks at DefaultDbAdapterFactory. It does this to create an adapter with dependency injection:

 return objectFactory.newInstance(DbAdapter.class, adapterType);

You might need to do something similar to instantiate your adapter with all the dependencies coming from Cayenne.

I am closing this Jira, as there's no more indication that this is a bug and I hope the above will work.
                
> Logger injection to JdbcAdapter subclass does not work
> ------------------------------------------------------
>
>                 Key: CAY-1655
>                 URL: https://issues.apache.org/jira/browse/CAY-1655
>             Project: Cayenne
>          Issue Type: Bug
>          Components: Core Library
>    Affects Versions: 3.1M3
>         Environment: Windows 7, MS Access, JdbcOdbc driver
>            Reporter: Wernke zur Borg
>
> I created a custom subclass of JdbcAdapter for some special handling with MS Access. It is instantiated by a custom DbAdapterFactory subclass, which is configured as:
> 		Module m = new Module() {
> 			public void configure(Binder binder) {
> 				binder.bind(DbAdapterFactory.class).to(MyCustomDbAdapterFactory.class);
> 			}
> 		};
> Now the application runs into a NullPointerException in org.apache.cayenne.access.jdbc.SelectAction.performAction() where it says:
> adapter.getJdbcEventLogger()...  (line 171)
> This means that the injection of the JdbcEventLogger "logger" in my superclass JdbcAdapter has not taken place. It might be important that also SelectAction has been subclassed with a custom SelectAction.
> The problem does not occur when I comment the binder.bind(...) line out.
> Workaround: Instantiate a CommonsJdbcEventLogger in the custom JdbcAdapter and assign it to the logger (it is protected). But this logger is not aware of the log4j log level. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira