You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/01 13:38:50 UTC
[GitHub] [flink] XComp commented on a change in pull request #13260: [FLINK-16768][tests] Let the watchdog also monitor mvn logs
XComp commented on a change in pull request #13260:
URL: https://github.com/apache/flink/pull/13260#discussion_r481144126
##########
File path: tools/ci/watchdog.sh
##########
@@ -38,8 +38,26 @@ CMD_EXIT="/tmp/watchdog.exit"
# Utility functions
# =============================================
+max_of() {
+ local max number
+
+ max="$1"
+
+ for number in "${@:2}"; do
+ if ((number > max)); then
+ max="$number"
+ fi
+ done
+
+ printf '%d\n' "$max"
Review comment:
:-D I like how the accepted answer feels to be 10 pages long for something I considered a minor thing ^^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org