You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by hucares <gi...@git.apache.org> on 2015/10/09 14:10:56 UTC
[GitHub] spark pull request: Spark 10262
GitHub user hucares opened a pull request:
https://github.com/apache/spark/pull/9046
Spark 10262
Annotations for attributes. Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hucares/spark SPARK-10262
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/9046.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #9046
----
commit 120003084519ac74ab78ee305a3d442afec3f444
Author: Alex Hu <a...@alexhu.me>
Date: 2015-10-09T10:26:18Z
SPARK-10262 Annotation for AttributeGroup
commit 1fa2e57b3b1d16214ef5c79c5eb003c0f2cdf20e
Author: Alex Hu <a...@alexhu.me>
Date: 2015-10-09T10:44:39Z
SPARK-10262 Annotations for AttributeType
commit 4d305e55fad7930a57e9dbd12278463b0247cf82
Author: Alex Hu <a...@alexhu.me>
Date: 2015-10-09T11:17:00Z
SPARK-10262 add annotations for attributes
commit eb37a0de3e571464a170566faff3da3ae05305b4
Author: Alex Hu <ve...@gmail.com>
Date: 2015-10-09T12:10:09Z
SPARK-10262 fixed several annotation bugs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-10262 Add @Since annotation to ml.attrib...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9046
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Spark 10262
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9046#issuecomment-146847519
(Please give this a more complete title and description, as in the JIRA)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-10262 Add @Since annotation to ml.attrib...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9046#issuecomment-146861246
[Test build #1867 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1867/console) for PR 9046 at commit [`eb37a0d`](https://github.com/apache/spark/commit/eb37a0de3e571464a170566faff3da3ae05305b4).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `sealed abstract class AttributeType(@Since("1.4.0") val name: String)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-10262 Add @Since annotation to ml.attrib...
Posted by hucares <gi...@git.apache.org>.
Github user hucares commented on the pull request:
https://github.com/apache/spark/pull/9046#issuecomment-146949198
@mengxr There are only `DeveloperApi` and now `Since` annotations under `ml.attribute`. I'm still pretty raw at Scala so I'm not sure why annotating a sealed abstract class creates a new class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-10262 Add @Since annotation to ml.attrib...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9046#issuecomment-174656433
I closed this PR. @hucares I'm sorry for not checking the API visibility when I created the JIRA. Please feel free to pick another starter task and I'm happy to walk you through the process of contributing to Spark.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-10262 Add @Since annotation to ml.attrib...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9046#issuecomment-174464961
@hucares I think you can close this PR. As you say in the JIRA, there are no non-Developer non-private APIs in this package.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Spark 10262
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9046#issuecomment-146847132
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Spark 10262
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9046#issuecomment-146847703
[Test build #1867 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1867/consoleFull) for PR 9046 at commit [`eb37a0d`](https://github.com/apache/spark/commit/eb37a0de3e571464a170566faff3da3ae05305b4).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-10262 Add @Since annotation to ml.attrib...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/9046#issuecomment-146927346
@hucares This could be my fault. Do you see any non-`DeveloperApi` under `ml.attribute`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org