[GitHub] [james-project] Arsnael commented on a change in pull request #358: [REFACTORING] JMAP: All ids should be backed by IdConstraint

[GitBox <gi...@apache.org>]

Arsnael commented on a change in pull request #358:
URL: https://github.com/apache/james-project/pull/358#discussion_r606917208



##########
File path: server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/VacationResponseGetMethodContract.scala
##########
@@ -482,14 +482,16 @@ trait VacationResponseGetMethodContract {
       .asString
       .stripMargin
 
-    assertThatJson(response).isEqualTo(
+    assertThatJson(response)
+      .whenIgnoringPaths("methodResponses[0][1].description")

Review comment:
       Why ignoring the description path here, and then why keeping it and changing the description in the assert below then?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org