You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nitin-maharana <gi...@git.apache.org> on 2016/11/25 12:42:19 UTC
[GitHub] cloudstack pull request #1786: CLOUDSTACK-9618: Load Balancer configuration ...
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1786
CLOUDSTACK-9618: Load Balancer configuration page does not have "Source" method in the drop down list.
If we create an isolated network with NetScaler published service offering for Load balancing service, then the load balancing configuration UI does not show "Source" as one of the supported LB methods in the drop down list. It only shows "Round-Robin" and "LeastConnection" methods in the list. However, It successfully creates LB rule with "Source" as the LB method using API.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nitin-maharana/CloudStack-Nitin nitin5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1786.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1786
----
commit 709343a0abf9ee00ef7c5ad6ebc70ff7cf1df57a
Author: Nitin Kumar Maharana <ni...@accelerite.com>
Date: 2016-11-25T12:37:17Z
CLOUDSTACK-9618: Load Balancer configuration page does not have "Source" method in the drop down list
Added the source method to supported algorithm list in Netscaler element.
Added a validation check.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1786: CLOUDSTACK-9618: Load Balancer configuration page do...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1786
LGTM based on code review
@karuturi Since this is a network plugin related fix and requires Netscaler, I don't think there is a need to run the BVTs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1786: CLOUDSTACK-9618: Load Balancer configuration ...
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1786#discussion_r90487461
--- Diff: plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java ---
@@ -260,7 +264,7 @@ public boolean applyLBRules(Network config, List<LoadBalancingRule> rules) throw
Map<Capability, String> lbCapabilities = new HashMap<Capability, String>();
// Specifies that the RoundRobin and Leastconn algorithms are supported for load balancing rules
- lbCapabilities.put(Capability.SupportedLBAlgorithms, "roundrobin,leastconn");
+ lbCapabilities.put(Capability.SupportedLBAlgorithms, "roundrobin,leastconn,source");
--- End diff --
The list of strings declared on this line must be sync with the list used to validate the algorithm on line 237. Therefore, please consider extracting this list to a constant `ImmutableSet<String>`, `SUPPORTED_ALGORITHMS` in order to ensure cohesion between declaration and validation. With this change, the validateLBRule can be re-implemented as follows:
```java
public boolean validateLBRule(Network network, LoadBalancingRule rule) {
Preconditions.checkArgument(network != null, "validateLBRule requires a non-null network");
Preconditions.checkArgument(rule != null, "validateLBRule requires a non-null rule");
return (canHandle(network, Service.Lb)) : SUPPORTED_ALGORITHMS.contains(rule.getAlgorithm()) : true;
}
```
This line can be re-implemented as follows:
```java
lbCapabilities.put(Capability.SupportedLBAlgorithms, Joiner.on(",").join(SUPPORTED_ALGORITHMS));
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1786: CLOUDSTACK-9618: Load Balancer configuration page do...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/1786
@jburwell : As this is Netscaler specific. Yes, you need a Netscaler to verify.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1786: CLOUDSTACK-9618: Load Balancer configuration page do...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/1786
Changed the base branch to 4.9.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1786: CLOUDSTACK-9618: Load Balancer configuration page do...
Posted by nitin-maharana <gi...@git.apache.org>.
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/1786
ping @sateesh-chodapuneedi @rajesh-battala @karuturi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---