You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/09/15 20:29:52 UTC
Review Request 25653: Added store APIs to query for IJobUpdate and
IJobUpdateConfiguration.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25653/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Repository: aurora
Description
-------
This addresses a couple of TODOs in the upcoming https://reviews.apache.org/r/25529/
Also, dropped redundant "instanceOverrides != null" check to bring up the branch coverage to 100%.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java b894a71348d2d71c077f35bb21a80ba88a6b4c42
src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 599dbd8bb762d051b75aa1a1e4d6a4c90ca6eb87
src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java ec9b37ccaf03651e986aab9b4541f17ff0540008
src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java 53f7a9b21f4858af7b3119b1b2ba5a7fdb3a3099
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml e59e6f77d08ecc68a73dabf77b68f3f8c95f5ed5
src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 0be4d78dd737b34f8a58276be9ffd7aeaa7f95bb
Diff: https://reviews.apache.org/r/25653/diff/
Testing
-------
gradle -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 25653: Added store APIs to query for IJobUpdate and
IJobUpdateConfiguration.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25653/
-----------------------------------------------------------
(Updated Sept. 15, 2014, 7:16 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
CR comments.
Repository: aurora
Description
-------
This addresses a couple of TODOs in the upcoming https://reviews.apache.org/r/25529/
Also, dropped redundant "instanceOverrides != null" check to bring up the branch coverage to 100%.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java b894a71348d2d71c077f35bb21a80ba88a6b4c42
src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 599dbd8bb762d051b75aa1a1e4d6a4c90ca6eb87
src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java ec9b37ccaf03651e986aab9b4541f17ff0540008
src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java 53f7a9b21f4858af7b3119b1b2ba5a7fdb3a3099
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml e59e6f77d08ecc68a73dabf77b68f3f8c95f5ed5
src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 0be4d78dd737b34f8a58276be9ffd7aeaa7f95bb
Diff: https://reviews.apache.org/r/25653/diff/
Testing
-------
gradle -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 25653: Added store APIs to query for IJobUpdate and
IJobUpdateConfiguration.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25653/#review53379
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java
<https://reviews.apache.org/r/25653/#comment93027>
s/of/of a/
src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java
<https://reviews.apache.org/r/25653/#comment93028>
s/of/of a/
- Bill Farner
On Sept. 15, 2014, 6:29 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25653/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2014, 6:29 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This addresses a couple of TODOs in the upcoming https://reviews.apache.org/r/25529/
>
> Also, dropped redundant "instanceOverrides != null" check to bring up the branch coverage to 100%.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java b894a71348d2d71c077f35bb21a80ba88a6b4c42
> src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 599dbd8bb762d051b75aa1a1e4d6a4c90ca6eb87
> src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java ec9b37ccaf03651e986aab9b4541f17ff0540008
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java 53f7a9b21f4858af7b3119b1b2ba5a7fdb3a3099
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml e59e6f77d08ecc68a73dabf77b68f3f8c95f5ed5
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 0be4d78dd737b34f8a58276be9ffd7aeaa7f95bb
>
> Diff: https://reviews.apache.org/r/25653/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>