You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/01/16 19:36:32 UTC

[GitHub] cjolivier01 commented on a change in pull request #9369: UT fix for Windows

cjolivier01 commented on a change in pull request #9369: UT fix for Windows
URL: https://github.com/apache/incubator-mxnet/pull/9369#discussion_r161858079
 
 

 ##########
 File path: tests/CMakeLists.txt
 ##########
 @@ -21,7 +21,7 @@ if(NOT MSVC)
 endif()
 
 # FIXME MSVC unit test linking issue
-if(GTEST_FOUND AND NOT MSVC)
+if(GTEST_FOUND)
 
 Review comment:
   This works now? Nice!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services