[GitHub] johnyangk commented on a change in pull request #122: [NEMO-213] Use Beam's DoFnRunners to execute DoFn

[GitBox <gi...@apache.org>]

johnyangk commented on a change in pull request #122: [NEMO-213] Use Beam's DoFnRunners to execute DoFn
URL: https://github.com/apache/incubator-nemo/pull/122#discussion_r223652673
 
 

 ##########
 File path: compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/BeamKeyExtractor.java
 ##########
 @@ -25,12 +26,19 @@
 final class BeamKeyExtractor implements KeyExtractor {
   @Override
   public Object extractKey(final Object element) {
-    if (element instanceof KV) {
-      // Handle null keys, since Beam allows KV with null keys.
-      final Object key = ((KV) element).getKey();
-      return key == null ? 0 : key;
-    } else {
-      return element;
+    // TODO #: do not dynamically check the types for performance improvement
 
 Review comment:
   Remove? - I don't think we can avoid dynamic checking as the runtime is agnostic to key types. Also maybe JVM branch prediction helps us here regarding performance.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services