You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by iamrupok <gi...@git.apache.org> on 2017/06/12 07:28:13 UTC
[GitHub] fineract pull request #365: PR AdHocQuery API
GitHub user iamrupok opened a pull request:
https://github.com/apache/fineract/pull/365
PR AdHocQuery API
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iamrupok/fineract develop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/fineract/pull/365.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #365
----
commit f3f5028191737789e9aec7633360e008751dfffd
Author: Kasem <ia...@gmail.com>
Date: 2017-06-12T07:24:39Z
AdHocQuery API
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract issue #365: PR AdHocQuery API
Posted by iamrupok <gi...@git.apache.org>.
Github user iamrupok commented on the issue:
https://github.com/apache/fineract/pull/365
yes
On Mon, Jun 12, 2017 at 3:08 PM, Shaik Nazeer Hussain <
notifications@github.com> wrote:
> @iamrupok <https://github.com/iamrupok> changes looks OK. I see
> CommandProcessingResult disableAdHocQuery(Long adHocId);
> CommandProcessingResult enableAdHocQuery(Long adHocId) methods which are
> not called from any API. Are you going to expose these api(s) in future?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/365#issuecomment-307732579>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ALCNB_TW7m5hcqw_Yp3CoLo9sLXwJafYks5sDP_ygaJpZM4N2veR>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract pull request #365: PR AdHocQuery API
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/365#discussion_r121935605
--- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/V329__adhocquery_changes.sql ---
@@ -0,0 +1,21 @@
+--
--- End diff --
You can put this script into V328__adhocquery.sql as this PR is not yet merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract pull request #365: PR AdHocQuery API
Posted by iamrupok <gi...@git.apache.org>.
Github user iamrupok commented on a diff in the pull request:
https://github.com/apache/fineract/pull/365#discussion_r121987168
--- Diff: fineract-provider/src/main/resources/sql/migrations/core_db/V329__adhocquery_changes.sql ---
@@ -0,0 +1,21 @@
+--
--- End diff --
moved to same file
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract issue #365: PR AdHocQuery API
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/365
@iamrupok changes looks OK. I see CommandProcessingResult disableAdHocQuery(Long adHocId);
CommandProcessingResult enableAdHocQuery(Long adHocId) methods which are not called from any API. Are you going to expose these api(s) in future?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract issue #365: PR AdHocQuery API
Posted by iamrupok <gi...@git.apache.org>.
Github user iamrupok commented on the issue:
https://github.com/apache/fineract/pull/365
for community-app to home should i send PR
On Wed, Jun 14, 2017 at 8:27 PM, Mohammad A. rupok <ia...@gmail.com>
wrote:
> create a new PR #369 please review and marge
>
>
> On Wed, Jun 14, 2017 at 7:47 PM, Mohammad A. rupok <ia...@gmail.com>
> wrote:
>
>> ok
>>
>> On Wed, Jun 14, 2017 at 6:49 PM, Shaik Nazeer Hussain <
>> notifications@github.com> wrote:
>>
>>> *@nazeer1100126* commented on this pull request.
>>>
>>> I suggest not to add new changes for already reviewed PR. For now, close
>>> this PR and send all changes with single commit.
>>> ------------------------------
>>>
>>> In fineract-provider/src/main/java/org/apache/fineract/adhocque
>>> ry/service/AdHocScheduledJobRunnerServiceImpl.java
>>> <https://github.com/apache/fineract/pull/365#discussion_r121935446>:
>>>
>>> > + private final AdHocReadPlatformService adHocReadPlatformService;
>>> +
>>> + @Autowired
>>> + public AdHocScheduledJobRunnerServiceImpl(final RoutingDataSourceServiceFactory dataSourceServiceFactory,
>>> + final AdHocReadPlatformService adHocReadPlatformService
>>> + ) {
>>> + this.dataSourceServiceFactory = dataSourceServiceFactory;
>>> + this.adHocReadPlatformService = adHocReadPlatformService;
>>> +
>>> + }
>>> +
>>> + @Transactional
>>> + @Override
>>> + @CronTarget(jobName = JobName.GENERATE_ADHOCCLIENT_SCEHDULE)
>>> + public void generateClientSchedule() {
>>> + final JdbcTemplate jdbcTemplate = new JdbcTemplate(this.dataSourceServiceFactory.determineDataSourceService().retrieveDataSource());
>>>
>>> You can create jdbcTemplate by autowiring RoutingDataSource dataSource
>>> in the constructor itself? Instead of creating the JDBCTemplate object here?
>>> ------------------------------
>>>
>>> In fineract-provider/src/main/resources/sql/migrations/core_db/
>>> V329__adhocquery_changes.sql
>>> <https://github.com/apache/fineract/pull/365#discussion_r121935605>:
>>>
>>> > @@ -0,0 +1,21 @@
>>> +--
>>>
>>> You can put this script into V328__adhocquery.sql as this PR is not yet
>>> merged
>>>
>>> —
>>> You are receiving this because you were mentioned.
>>> Reply to this email directly, view it on GitHub
>>> <https://github.com/apache/fineract/pull/365#pullrequestreview-44004421>,
>>> or mute the thread
>>> <https://github.com/notifications/unsubscribe-auth/ALCNB81xmzrZuggoMNVQexl4pAczFYPYks5sD9bcgaJpZM4N2veR>
>>> .
>>>
>>
>>
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract issue #365: PR AdHocQuery API
Posted by iamrupok <gi...@git.apache.org>.
Github user iamrupok commented on the issue:
https://github.com/apache/fineract/pull/365
ok
On Wed, Jun 14, 2017 at 6:49 PM, Shaik Nazeer Hussain <
notifications@github.com> wrote:
> *@nazeer1100126* commented on this pull request.
>
> I suggest not to add new changes for already reviewed PR. For now, close
> this PR and send all changes with single commit.
> ------------------------------
>
> In fineract-provider/src/main/java/org/apache/fineract/adhocquery/service/
> AdHocScheduledJobRunnerServiceImpl.java
> <https://github.com/apache/fineract/pull/365#discussion_r121935446>:
>
> > + private final AdHocReadPlatformService adHocReadPlatformService;
> +
> + @Autowired
> + public AdHocScheduledJobRunnerServiceImpl(final RoutingDataSourceServiceFactory dataSourceServiceFactory,
> + final AdHocReadPlatformService adHocReadPlatformService
> + ) {
> + this.dataSourceServiceFactory = dataSourceServiceFactory;
> + this.adHocReadPlatformService = adHocReadPlatformService;
> +
> + }
> +
> + @Transactional
> + @Override
> + @CronTarget(jobName = JobName.GENERATE_ADHOCCLIENT_SCEHDULE)
> + public void generateClientSchedule() {
> + final JdbcTemplate jdbcTemplate = new JdbcTemplate(this.dataSourceServiceFactory.determineDataSourceService().retrieveDataSource());
>
> You can create jdbcTemplate by autowiring RoutingDataSource dataSource in
> the constructor itself? Instead of creating the JDBCTemplate object here?
> ------------------------------
>
> In fineract-provider/src/main/resources/sql/migrations/core_
> db/V329__adhocquery_changes.sql
> <https://github.com/apache/fineract/pull/365#discussion_r121935605>:
>
> > @@ -0,0 +1,21 @@
> +--
>
> You can put this script into V328__adhocquery.sql as this PR is not yet
> merged
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/365#pullrequestreview-44004421>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ALCNB81xmzrZuggoMNVQexl4pAczFYPYks5sD9bcgaJpZM4N2veR>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract issue #365: PR AdHocQuery API
Posted by iamrupok <gi...@git.apache.org>.
Github user iamrupok commented on the issue:
https://github.com/apache/fineract/pull/365
new PR #369
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract issue #365: PR AdHocQuery API
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/365
@iamrupok changes looks OK. I will merge this by EOD today
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract issue #365: PR AdHocQuery API
Posted by iamrupok <gi...@git.apache.org>.
Github user iamrupok commented on the issue:
https://github.com/apache/fineract/pull/365
for the ui part to home should i send PR request
On Mon, Jun 12, 2017 at 3:08 PM, Mohammad A. rupok <ia...@gmail.com>
wrote:
> yes
>
> On Mon, Jun 12, 2017 at 3:08 PM, Shaik Nazeer Hussain <
> notifications@github.com> wrote:
>
>> @iamrupok <https://github.com/iamrupok> changes looks OK. I see
>> CommandProcessingResult disableAdHocQuery(Long adHocId);
>> CommandProcessingResult enableAdHocQuery(Long adHocId) methods which are
>> not called from any API. Are you going to expose these api(s) in future?
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/apache/fineract/pull/365#issuecomment-307732579>, or mute
>> the thread
>> <https://github.com/notifications/unsubscribe-auth/ALCNB_TW7m5hcqw_Yp3CoLo9sLXwJafYks5sDP_ygaJpZM4N2veR>
>> .
>>
>
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract pull request #365: PR AdHocQuery API
Posted by iamrupok <gi...@git.apache.org>.
Github user iamrupok closed the pull request at:
https://github.com/apache/fineract/pull/365
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract issue #365: PR AdHocQuery API
Posted by iamrupok <gi...@git.apache.org>.
Github user iamrupok commented on the issue:
https://github.com/apache/fineract/pull/365
HI any update about the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract pull request #365: PR AdHocQuery API
Posted by iamrupok <gi...@git.apache.org>.
Github user iamrupok commented on a diff in the pull request:
https://github.com/apache/fineract/pull/365#discussion_r121987075
--- Diff: fineract-provider/src/main/java/org/apache/fineract/adhocquery/service/AdHocScheduledJobRunnerServiceImpl.java ---
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.adhocquery.service;
+
+import java.util.Collection;
+
+import org.apache.fineract.adhocquery.data.AdHocData;
+import org.apache.fineract.adhocquery.service.AdHocReadPlatformService;
+import org.apache.fineract.infrastructure.core.service.RoutingDataSourceServiceFactory;
+import org.apache.fineract.infrastructure.core.service.ThreadLocalContextUtil;
+import org.apache.fineract.infrastructure.jobs.annotation.CronTarget;
+import org.apache.fineract.infrastructure.jobs.service.JobName;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.jdbc.core.JdbcTemplate;
+import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
+
+@Service(value = "adHocScheduledJobRunnerService")
+public class AdHocScheduledJobRunnerServiceImpl implements AdHocScheduledJobRunnerService {
+
+ private final static Logger logger = LoggerFactory.getLogger(AdHocScheduledJobRunnerServiceImpl.class);
+ private final RoutingDataSourceServiceFactory dataSourceServiceFactory;
+ private final AdHocReadPlatformService adHocReadPlatformService;
+
+ @Autowired
+ public AdHocScheduledJobRunnerServiceImpl(final RoutingDataSourceServiceFactory dataSourceServiceFactory,
+ final AdHocReadPlatformService adHocReadPlatformService
+ ) {
+ this.dataSourceServiceFactory = dataSourceServiceFactory;
+ this.adHocReadPlatformService = adHocReadPlatformService;
+
+ }
+
+ @Transactional
+ @Override
+ @CronTarget(jobName = JobName.GENERATE_ADHOCCLIENT_SCEHDULE)
+ public void generateClientSchedule() {
+ final JdbcTemplate jdbcTemplate = new JdbcTemplate(this.dataSourceServiceFactory.determineDataSourceService().retrieveDataSource());
--- End diff --
yes i followed existing implementation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract issue #365: PR AdHocQuery API
Posted by iamrupok <gi...@git.apache.org>.
Github user iamrupok commented on the issue:
https://github.com/apache/fineract/pull/365
added more files
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract issue #365: PR AdHocQuery API
Posted by iamrupok <gi...@git.apache.org>.
Github user iamrupok commented on the issue:
https://github.com/apache/fineract/pull/365
create a new PR #369 please review and marge
On Wed, Jun 14, 2017 at 7:47 PM, Mohammad A. rupok <ia...@gmail.com>
wrote:
> ok
>
> On Wed, Jun 14, 2017 at 6:49 PM, Shaik Nazeer Hussain <
> notifications@github.com> wrote:
>
>> *@nazeer1100126* commented on this pull request.
>>
>> I suggest not to add new changes for already reviewed PR. For now, close
>> this PR and send all changes with single commit.
>> ------------------------------
>>
>> In fineract-provider/src/main/java/org/apache/fineract/adhocque
>> ry/service/AdHocScheduledJobRunnerServiceImpl.java
>> <https://github.com/apache/fineract/pull/365#discussion_r121935446>:
>>
>> > + private final AdHocReadPlatformService adHocReadPlatformService;
>> +
>> + @Autowired
>> + public AdHocScheduledJobRunnerServiceImpl(final RoutingDataSourceServiceFactory dataSourceServiceFactory,
>> + final AdHocReadPlatformService adHocReadPlatformService
>> + ) {
>> + this.dataSourceServiceFactory = dataSourceServiceFactory;
>> + this.adHocReadPlatformService = adHocReadPlatformService;
>> +
>> + }
>> +
>> + @Transactional
>> + @Override
>> + @CronTarget(jobName = JobName.GENERATE_ADHOCCLIENT_SCEHDULE)
>> + public void generateClientSchedule() {
>> + final JdbcTemplate jdbcTemplate = new JdbcTemplate(this.dataSourceServiceFactory.determineDataSourceService().retrieveDataSource());
>>
>> You can create jdbcTemplate by autowiring RoutingDataSource dataSource in
>> the constructor itself? Instead of creating the JDBCTemplate object here?
>> ------------------------------
>>
>> In fineract-provider/src/main/resources/sql/migrations/core_db/
>> V329__adhocquery_changes.sql
>> <https://github.com/apache/fineract/pull/365#discussion_r121935605>:
>>
>> > @@ -0,0 +1,21 @@
>> +--
>>
>> You can put this script into V328__adhocquery.sql as this PR is not yet
>> merged
>>
>> —
>> You are receiving this because you were mentioned.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/apache/fineract/pull/365#pullrequestreview-44004421>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/ALCNB81xmzrZuggoMNVQexl4pAczFYPYks5sD9bcgaJpZM4N2veR>
>> .
>>
>
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] fineract pull request #365: PR AdHocQuery API
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/365#discussion_r121935446
--- Diff: fineract-provider/src/main/java/org/apache/fineract/adhocquery/service/AdHocScheduledJobRunnerServiceImpl.java ---
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.adhocquery.service;
+
+import java.util.Collection;
+
+import org.apache.fineract.adhocquery.data.AdHocData;
+import org.apache.fineract.adhocquery.service.AdHocReadPlatformService;
+import org.apache.fineract.infrastructure.core.service.RoutingDataSourceServiceFactory;
+import org.apache.fineract.infrastructure.core.service.ThreadLocalContextUtil;
+import org.apache.fineract.infrastructure.jobs.annotation.CronTarget;
+import org.apache.fineract.infrastructure.jobs.service.JobName;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.jdbc.core.JdbcTemplate;
+import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
+
+@Service(value = "adHocScheduledJobRunnerService")
+public class AdHocScheduledJobRunnerServiceImpl implements AdHocScheduledJobRunnerService {
+
+ private final static Logger logger = LoggerFactory.getLogger(AdHocScheduledJobRunnerServiceImpl.class);
+ private final RoutingDataSourceServiceFactory dataSourceServiceFactory;
+ private final AdHocReadPlatformService adHocReadPlatformService;
+
+ @Autowired
+ public AdHocScheduledJobRunnerServiceImpl(final RoutingDataSourceServiceFactory dataSourceServiceFactory,
+ final AdHocReadPlatformService adHocReadPlatformService
+ ) {
+ this.dataSourceServiceFactory = dataSourceServiceFactory;
+ this.adHocReadPlatformService = adHocReadPlatformService;
+
+ }
+
+ @Transactional
+ @Override
+ @CronTarget(jobName = JobName.GENERATE_ADHOCCLIENT_SCEHDULE)
+ public void generateClientSchedule() {
+ final JdbcTemplate jdbcTemplate = new JdbcTemplate(this.dataSourceServiceFactory.determineDataSourceService().retrieveDataSource());
--- End diff --
You can create jdbcTemplate by autowiring RoutingDataSource dataSource in the constructor itself? Instead of creating the JDBCTemplate object here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---