[GitHub] [httpcomponents-client] ok2c commented on a change in pull request #149: Information responses (1xx) processing implemented.

[GitBox <gi...@apache.org>]

ok2c commented on a change in pull request #149: Information responses (1xx) processing implemented.
URL: https://github.com/apache/httpcomponents-client/pull/149#discussion_r287839351
 
 

 ##########
 File path: httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/AsyncRedirectExec.java
 ##########
 @@ -187,6 +192,19 @@ public AsyncDataConsumer handleResponse(
                 return asyncExecCallback.handleResponse(response, entityDetails);
             }
 
+            @Override
+            public void handleInformationResponse(final HttpResponse response) throws HttpException, IOException {
+                redirect(response);
 
 Review comment:
   @kirill-usov Are you sure about doing a redirect on an informational response? This does not look right to me. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org