You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ia...@apache.org on 2014/10/28 16:01:27 UTC
android commit: Fix reversed condition for isUrlHarmful
Repository: cordova-android
Updated Branches:
refs/heads/unplug-whitelist 7ff717315 -> c439565d1
Fix reversed condition for isUrlHarmful
Project: http://git-wip-us.apache.org/repos/asf/cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-android/commit/c439565d
Tree: http://git-wip-us.apache.org/repos/asf/cordova-android/tree/c439565d
Diff: http://git-wip-us.apache.org/repos/asf/cordova-android/diff/c439565d
Branch: refs/heads/unplug-whitelist
Commit: c439565d1bd705e65e8fdcc36383b54835e4d42e
Parents: 7ff7173
Author: Ian Clelland <ic...@chromium.org>
Authored: Tue Oct 28 11:00:49 2014 -0400
Committer: Ian Clelland <ic...@chromium.org>
Committed: Tue Oct 28 11:00:49 2014 -0400
----------------------------------------------------------------------
framework/src/org/apache/cordova/IceCreamCordovaWebViewClient.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-android/blob/c439565d/framework/src/org/apache/cordova/IceCreamCordovaWebViewClient.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/IceCreamCordovaWebViewClient.java b/framework/src/org/apache/cordova/IceCreamCordovaWebViewClient.java
index fbe048d..ccb5b75 100644
--- a/framework/src/org/apache/cordova/IceCreamCordovaWebViewClient.java
+++ b/framework/src/org/apache/cordova/IceCreamCordovaWebViewClient.java
@@ -72,7 +72,7 @@ public class IceCreamCordovaWebViewClient extends AndroidWebViewClient {
}
private boolean isUrlHarmful(String url) {
- Boolean shouldAllowRequest = !appView.getPluginManager().shouldAllowRequest(url);
+ Boolean shouldAllowRequest = appView.getPluginManager().shouldAllowRequest(url);
if (shouldAllowRequest == null || shouldAllowRequest == true) {
// This is the behaviour when all plugins return true, and is also the default behaviour
// if no plugins override shouldAllowRequest()
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org