You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/06/16 19:33:13 UTC

[kudu-CR] alter table-test: add a workaround for KUDU-791 

Hello Alexey Serbin,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/7210

to review the following change.

Change subject: alter_table-test: add a workaround for KUDU-791
......................................................................

alter_table-test: add a workaround for KUDU-791

KUDU-791 describes the fact that our AlterTable operations do not fully
respect our consistency guarantees. This test, however, was making
assertions on the alter-table success immediately after issuing an alter
table command.

The fix just switches to ASSERT_EVENTUALLY. I looped the test 500 times
with the change[1] and all passed.

I also looped 1000 times with 4 CPU stress threads[2]. I got two
failures which seem to be related to some clock-related test issue
separate from this change.

[1] http://dist-test.cloudera.org/job?job_id=todd.1497399757.25356
[2] httpL//dist-test.cloudera.org/job?job_id=todd.1497577640.27529

Change-Id: I63769f7a95928a2f25ad1d35b6cb346fa3d13bd4
---
M src/kudu/integration-tests/alter_table-test.cc
1 file changed, 19 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/7210/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I63769f7a95928a2f25ad1d35b6cb346fa3d13bd4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>

[kudu-CR] alter table-test: add a workaround for KUDU-791

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: alter_table-test: add a workaround for KUDU-791
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63769f7a95928a2f25ad1d35b6cb346fa3d13bd4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] alter table-test: add a workaround for KUDU-791

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.

Change subject: alter_table-test: add a workaround for KUDU-791
......................................................................


alter_table-test: add a workaround for KUDU-791

KUDU-791 describes the fact that our AlterTable operations do not fully
respect our consistency guarantees. This test, however, was making
assertions on the alter-table success immediately after issuing an alter
table command.

The fix just switches to ASSERT_EVENTUALLY. I looped the test 500 times
with the change[1] and all passed.

I also looped 1000 times with 4 CPU stress threads[2]. I got two
failures which seem to be related to some clock-related test issue
separate from this change.

[1] http://dist-test.cloudera.org/job?job_id=todd.1497399757.25356
[2] httpL//dist-test.cloudera.org/job?job_id=todd.1497577640.27529

Change-Id: I63769f7a95928a2f25ad1d35b6cb346fa3d13bd4
Reviewed-on: http://gerrit.cloudera.org:8080/7210
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/integration-tests/alter_table-test.cc
1 file changed, 19 insertions(+), 13 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I63769f7a95928a2f25ad1d35b6cb346fa3d13bd4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins