You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Shuai Lin <li...@gmail.com> on 2016/01/07 14:55:55 UTC

Re: Review Request 42011: Added gtest flags to generate xml report.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42011/
-----------------------------------------------------------

(Updated Jan. 7, 2016, 1:55 p.m.)


Review request for mesos, Ben Mahler and haosdent huang.


Summary (updated)
-----------------

Added gtest flags to generate xml report.


Bugs: MESOS-4258
    https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description
-------

Added gtest flags to generate xml report.


Diffs
-----

  Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
  support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e 

Diff: https://reviews.apache.org/r/42011/diff/


Testing
-------

$ export GTEST_OUTPUT=xml:report.xml
$ make check
$ find . -name report.xml                                                                                                                                    
./3rdparty/libprocess/report.xml
./3rdparty/libprocess/3rdparty/report.xml
./src/report.xml


Thanks,

Shuai Lin

Re: Review Request 42011: Added gtest flags to generate xml report.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42011/#review113536
-----------------------------------------------------------

Ship it!


Thank you! This is very helpful to the project. We'll get this committed shortly.


support/docker_build.sh (line 70)
<https://reviews.apache.org/r/42011/#comment174274>

    I'll add a period here.


- Ben Mahler


On Jan. 7, 2016, 1:55 p.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42011/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 1:55 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-4258
>     https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added gtest flags to generate xml report.
> 
> 
> Diffs
> -----
> 
>   Makefile.am d9604f48f194dc8272423410e9938e646f334a9c 
>   support/docker_build.sh 7882bd20e4b6ee28dc117086386de8faac995a3e 
> 
> Diff: https://reviews.apache.org/r/42011/diff/
> 
> 
> Testing
> -------
> 
> $ export GTEST_OUTPUT=xml:report.xml
> $ make check
> $ find . -name report.xml                                                                                                                                    
> ./3rdparty/libprocess/report.xml
> ./3rdparty/libprocess/3rdparty/report.xml
> ./src/report.xml
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>