[GitHub] [airflow] brokenjacobs commented on pull request #8287: [AIRFLOW-4363] Fix JSON encoding error

[GitBox <gi...@apache.org>]

brokenjacobs commented on pull request #8287:
URL: https://github.com/apache/airflow/pull/8287#issuecomment-622597778


   The docker docs are definitely wrong. As you can see if you try to run the operator code as it exists in 10.10. 
   
   It doesn’t mean they won’t decide sometime to make the docs be accurate. I’m supportive of the way this change was implemented.
   
   - Steve Jacobs
   
   > On May 1, 2020, at 4:04 PM, retornam <no...@github.com> wrote:
   > 
   > 
   > @retornam commented on this pull request.
   > 
   > In airflow/providers/docker/operators/docker.py:
   > 
   > > +            for output in self.cli.pull(self.image, stream=True, decode=True):
   > +                if isinstance(output, str):
   > +                    self.log.info("%s", output)
   > +                if isinstance(output, dict) and 'status' in output:
   > @acroos and then right below it is says (generator or str) for return Type
   > 
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub, or unsubscribe.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org