You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ganeshmurthy <gi...@git.apache.org> on 2018/07/23 19:25:03 UTC
[GitHub] qpid-dispatch pull request #345: DISPATCH-1085 - Modified AMQP_link_detach_h...
GitHub user ganeshmurthy opened a pull request:
https://github.com/apache/qpid-dispatch/pull/345
DISPATCH-1085 - Modified AMQP_link_detach_handler to flush out the re…
…maining bytes in the message buffers before responding to detaches
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1085
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/345.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #345
----
commit 3d19ec903881ec2b66b9b014f0f037a67ea40952
Author: Ganesh Murthy <gm...@...>
Date: 2018-07-23T19:21:44Z
DISPATCH-1085 - Modified AMQP_link_detach_handler to flush out the remaining bytes in the message buffers before responding to detaches
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #345: DISPATCH-1085 - Modified AMQP_link_detach_handler ...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/qpid-dispatch/pull/345
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/345?src=pr&el=h1) Report
> Merging [#345](https://codecov.io/gh/apache/qpid-dispatch/pull/345?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/53493714c631ebfdaa0687525a0da531b44f1ea9?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/345?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #345 +/- ##
==========================================
+ Coverage 84.29% 84.31% +0.01%
==========================================
Files 69 69
Lines 15674 15684 +10
==========================================
+ Hits 13213 13224 +11
+ Misses 2461 2460 -1
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/345?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `88.09% <100%> (+0.64%)` | :arrow_up: |
| [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `94.18% <81.81%> (-0.48%)` | :arrow_down: |
| [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.1% <0%> (-0.46%)` | :arrow_down: |
| [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `95.2% <0%> (-0.23%)` | :arrow_down: |
| [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `70.7% <0%> (+0.19%)` | :arrow_up: |
| [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `86.06% <0%> (+0.23%)` | :arrow_up: |
| [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `99.26% <0%> (+0.36%)` | :arrow_up: |
| [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/345/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.79% <0%> (+0.57%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/345?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/345?src=pr&el=footer). Last update [5349371...3d19ec9](https://codecov.io/gh/apache/qpid-dispatch/pull/345?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #345: DISPATCH-1085 - Modified AMQP_link_detach_h...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/345
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #345: DISPATCH-1085 - Modified AMQP_link_detach_h...
Posted by ted-ross <gi...@git.apache.org>.
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/345#discussion_r206499598
--- Diff: src/message.c ---
@@ -1128,13 +1128,15 @@ qd_message_t *qd_message_receive(pn_delivery_t *delivery)
return discard_receive(delivery, link, (qd_message_t *)msg);
}
+ // if q2 holdoff has been disabled (disable_q2_holdoff=true), we keep receiving.
+ // if q2 holdoff has been enabled (disable_q2_holdoff=false), if input is in holdoff then just exit.
+ // When enough buffers
+ // have been processed and freed by outbound processing then
+ // message holdoff is cleared and receiving may continue.
//
- // If input is in holdoff then just exit. When enough buffers
- // have been processed and freed by outbound processing then
- // message holdoff is cleared and receiving may continue.
- //
- if (msg->content->q2_input_holdoff) {
- return (qd_message_t*)msg;
+ if (!msg->content->disable_q2_holdoff) {
--- End diff --
Is this change necessary? Was there a bug in qd_message_holdoff_Q2_disable?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org