[GitHub] [doris] zhannngchen commented on a diff in pull request #11252: [feature-wip](unique-key-merge-on-write) update counter, DSIP-018

[GitBox <gi...@apache.org>]

zhannngchen commented on code in PR #11252:
URL: https://github.com/apache/doris/pull/11252#discussion_r930962924


##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -156,7 +156,9 @@ Status SegmentIterator::_init(bool is_vec) {
     // Remove rows that have been marked deleted
     if (_opts.delete_bitmap.count(segment_id()) > 0 &&
         _opts.delete_bitmap[segment_id()] != nullptr) {
+        size_t pre_size = _row_bitmap.cardinality();
         _row_bitmap -= *(_opts.delete_bitmap[segment_id()]);

Review Comment:
   Why do we need such a CHECK here? Do you want to ensure that the delete_bitmap is not empty?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org