You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/27 01:19:00 UTC
[jira] [Work logged] (BEAM-11695) Remove
translations.pack_combiners optimizer from defaults
[ https://issues.apache.org/jira/browse/BEAM-11695?focusedWorklogId=542549&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-542549 ]
ASF GitHub Bot logged work on BEAM-11695:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jan/21 01:18
Start Date: 27/Jan/21 01:18
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #13763:
URL: https://github.com/apache/beam/pull/13763#issuecomment-761092376
# [Codecov](https://codecov.io/gh/apache/beam/pull/13763?src=pr&el=h1) Report
> Merging [#13763](https://codecov.io/gh/apache/beam/pull/13763?src=pr&el=desc) (6b0a41f) into [master](https://codecov.io/gh/apache/beam/commit/4c81134dd9206fd6cb9060a9b973fc111b8fbd64?el=desc) (4c81134) will **increase** coverage by `0.06%`.
> The diff coverage is `76.47%`.
[](https://codecov.io/gh/apache/beam/pull/13763?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13763 +/- ##
==========================================
+ Coverage 82.77% 82.83% +0.06%
==========================================
Files 466 466
Lines 57562 57582 +20
==========================================
+ Hits 47647 47700 +53
+ Misses 9915 9882 -33
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/13763?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/13763/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `89.73% <ø> (ø)` | |
| [...on/apache\_beam/runners/dataflow/dataflow\_runner.py](https://codecov.io/gh/apache/beam/pull/13763/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXIucHk=) | `82.98% <60.00%> (+4.52%)` | :arrow_up: |
| [...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/13763/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5) | `94.60% <100.00%> (ø)` | |
| [...ache\_beam/runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/13763/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `91.06% <100.00%> (+0.69%)` | :arrow_up: |
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/13763/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.85% <0.00%> (-2.39%)` | :arrow_down: |
| [sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/13763/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=) | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
| [sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/13763/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==) | `91.15% <0.00%> (-0.83%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/13763/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=) | `91.37% <0.00%> (-0.08%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/13763/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `84.81% <0.00%> (+0.26%)` | :arrow_up: |
| ... and [6 more](https://codecov.io/gh/apache/beam/pull/13763/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/13763?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/13763?src=pr&el=footer). Last update [7c4a21a...6b0a41f](https://codecov.io/gh/apache/beam/pull/13763?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 542549)
Remaining Estimate: 0h
Time Spent: 10m
> Remove translations.pack_combiners optimizer from defaults
> ----------------------------------------------------------
>
> Key: BEAM-11695
> URL: https://issues.apache.org/jira/browse/BEAM-11695
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Yifan Mai
> Priority: P2
> Fix For: 2.28.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently this optimizer is run by default in DataflowRunner, FnApiRunner and PortableRunner. We should remove it and only enable it under an experiment flag until BEAM-11644 is resolved.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)