You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/03 10:24:55 UTC

[GitHub] [arrow-rs] alamb opened a new pull request, #2295: [Minor] Improve types shown in cast error messages

alamb opened a new pull request, #2295:
URL: https://github.com/apache/arrow-rs/pull/2295

   # Which issue does this PR close?
   
   N/A
   
   # Rationale for this change
    
   
   As suggested by @viirya  on https://github.com/apache/arrow-rs/pull/2284#discussion_r936157060 the amount of qualification on the types in cast error messages is both not helpful it may actually obscure the actual problem
   
   
   # What changes are included in this PR?
   
   
   Use standard `fmt::Debug` printing for type names in error messages, as done in the rest of the file
   
   
   # Are there any user-facing changes?
   Instead of looking like
   
   ```
   Cast error: Cannot cast ... to value of arrow::datatypes::types::Time32SecondType type
   ```
   
   Errors now look like
   
   ```
   Cast error: Cannot cast ... to value of Time32 type
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] ursabot commented on pull request #2295: [Minor] Improve types shown in cast error messages

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2295:
URL: https://github.com/apache/arrow-rs/pull/2295#issuecomment-1203909850

   Benchmark runs are scheduled for baseline = 1cc85635bd921ccd1e84b04ab0b8a00e100c26b3 and contender = 22185fd597334c1d3a2e36a2bfba09be02466df9. 22185fd597334c1d3a2e36a2bfba09be02466df9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/575b50ce8862451d985cecdeca746c83...cf13ac0a01e1451a8d35340296641568/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a199b74634fd4b21917c25d9e9d3f458...e2015713dc5b4b95b83080e97f5b502f/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/5f5987d899ce4c08aa361b993e299399...8ee81a71077044ed8367265f4890e3ab/)
   [Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/7329bbe7b83d4b6eaf35697c4072e02c...40de878bf36d42be8dc8ca9a8173eb04/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] codecov-commenter commented on pull request #2295: [Minor] Improve types shown in cast error messages

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2295:
URL: https://github.com/apache/arrow-rs/pull/2295#issuecomment-1203901040

   # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2295?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2295](https://codecov.io/gh/apache/arrow-rs/pull/2295?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68954b8) into [master](https://codecov.io/gh/apache/arrow-rs/commit/299908ee0c12edb1e720ed9a0465cb7af8352cb3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (299908e) will **decrease** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2295      +/-   ##
   ==========================================
   - Coverage   82.14%   82.14%   -0.01%     
   ==========================================
     Files         248      248              
     Lines       63492    63493       +1     
   ==========================================
   - Hits        52158    52156       -2     
   - Misses      11334    11337       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/2295?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [arrow/src/compute/kernels/cast.rs](https://codecov.io/gh/apache/arrow-rs/pull/2295/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9jYXN0LnJz) | `97.17% <100.00%> (+<0.01%)` | :arrow_up: |
   | [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/2295/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `62.30% <0.00%> (-0.32%)` | :arrow_down: |
   | [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/2295/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.75% <0.00%> (-0.23%)` | :arrow_down: |
   | [parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow-rs/pull/2295/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvc2NoZW1hLnJz) | `96.76% <0.00%> (-0.18%)` | :arrow_down: |
   
   Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold merged pull request #2295: [Minor] Improve types shown in cast error messages

Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2295:
URL: https://github.com/apache/arrow-rs/pull/2295


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org