You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/11/23 11:36:00 UTC
[jira] [Work logged] (HADOOP-18021) Provide a public wrapper of Configuration#substituteVars
[ https://issues.apache.org/jira/browse/HADOOP-18021?focusedWorklogId=685197&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685197 ]
ASF GitHub Bot logged work on HADOOP-18021:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Nov/21 11:35
Start Date: 23/Nov/21 11:35
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request #3710:
URL: https://github.com/apache/hadoop/pull/3710#discussion_r755034309
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
##########
@@ -1099,6 +1099,20 @@ private synchronized void addResourceObject(Resource resource) {
return result;
}
+ /**
+ * Provides a public wrapper over substituteVars in order to avoid compatibility issues.
+ * See YARN-11013 for further details.
Review comment:
replace with HADOOP-18021
##########
File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
##########
@@ -1126,7 +1140,7 @@ private synchronized void addResourceObject(Resource resource) {
* @throws IllegalArgumentException when more than
* {@link Configuration#MAX_SUBST} replacements are required
*/
- public String substituteVars(String expr) {
+ private String substituteVars(String expr) {
Review comment:
mention in the javadocs that oozie has a subclass with a method of this name, so it must be kept private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 685197)
Time Spent: 20m (was: 10m)
> Provide a public wrapper of Configuration#substituteVars
> --------------------------------------------------------
>
> Key: HADOOP-18021
> URL: https://issues.apache.org/jira/browse/HADOOP-18021
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Andras Gyori
> Assignee: Andras Gyori
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> YARN-10838 and YARN-10911 introduced an unfortunate change in Configuration that could potentially be backward incompatible (visibility of substituteVars). Since it is easily circumvented, my proposal is to avoid breaking changes if possible.
> One found issue is that Oozie defines substituteVars as a private method.
> https://github.com/apache/oozie/blob/master/core/src/main/java/org/apache/oozie/util/XConfiguration.java#L186
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org