You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/03/24 13:01:49 UTC
Review Request 57910: Create a base class for caching in ambari-agent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57910/
-----------------------------------------------------------
Review request for Ambari and Sid Wagle.
Bugs: AMBARI-20559
https://issues.apache.org/jira/browse/AMBARI-20559
Repository: ambari
Description
-------
The class should be:
1\. Thread-safe
2\. Support caching for multiple clusters
3\. Write cache to json file for debug purposes.
In next jiras the class with be derived by ClusterConfigurationCache,
ClusterTopologyCache and ClusterComponentsStatusCache.
We have already a caching class for alerts. The jira should also rewrite it to
use the base class.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/ClusterCache.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/ClusterConfiguration.py 72b87be
ambari-agent/src/main/python/ambari_agent/ClusterConfigurationCache.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/ClusterTopologyCache.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/Controller.py 78b5c0c
ambari-agent/src/main/python/ambari_agent/FileCache.py d0c8bdb
ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 7f3b2a5
ambari-agent/src/test/python/ambari_agent/TestAlerts.py 64479a2
ambari-agent/src/test/python/ambari_agent/TestClusterConfigurationCache.py a418f6d
Diff: https://reviews.apache.org/r/57910/diff/1/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 57910: Create a base class for caching in
ambari-agent.
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57910/
-----------------------------------------------------------
(Updated March 24, 2017, 1:05 p.m.)
Review request for Ambari and Sid Wagle.
Bugs: AMBARI-20559
https://issues.apache.org/jira/browse/AMBARI-20559
Repository: ambari
Description
-------
The class should be:
1\. Thread-safe
2\. Support caching for multiple clusters
3\. Write cache to json file for debug purposes.
In next jiras the class with be derived by ClusterConfigurationCache,
ClusterTopologyCache and ClusterComponentsStatusCache.
We have already a caching class for alerts. The jira should also rewrite it to
use the base class.
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/ClusterCache.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/ClusterConfiguration.py 72b87be
ambari-agent/src/main/python/ambari_agent/ClusterConfigurationCache.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/Controller.py 78b5c0c
ambari-agent/src/main/python/ambari_agent/FileCache.py d0c8bdb
ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 7f3b2a5
ambari-agent/src/test/python/ambari_agent/TestAlerts.py 64479a2
ambari-agent/src/test/python/ambari_agent/TestClusterConfigurationCache.py a418f6d
Diff: https://reviews.apache.org/r/57910/diff/2/
Changes: https://reviews.apache.org/r/57910/diff/1-2/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk